I did some alignment testing against babel and found they handled some things differently. I decided their way was better, so updating the representation to match.

Previously:

we emitted a different AST for pre-3.9 and post-3.9
we treatedTSNonNullExpression as a breakage in the chain, meaning that theChainExpression would not move up through them.

Now:

we emit the same AST regardless of TS version
we treatTSNonNullExpression as aChainElement, so theChainExpression always moves past them in the tree

fix(typescript-estree): correct ChainExpression interaction with pare…

614e3ad

…ntheses and non-nulls

bradzacher added the bugSomething isn't working label

Aug 10, 2020

bradzacher added this to the4.0.0 milestone

Aug 10, 2020

Copy link

Contributor

typescript-eslintbot commentedAug 10, 2020

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

codecovbot commentedAug 10, 2020

Codecov Report

Merging#2380 intov4 willdecrease coverage by0.15%.
The diff coverage is56.09%.

@@            Coverage Diff             @@##               v4    #2380      +/-   ##==========================================- Coverage   92.96%   92.81%   -0.16%==========================================  Files         286      286                Lines        9046     9048       +2       Branches     2514     2509       -5     ==========================================- Hits         8410     8398      -12- Misses        305      320      +15+ Partials      331      330       -1

Flag	Coverage Δ
#unittest	`92.81% <56.09%> (-0.16%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts	`100.00% <ø> (ø)`
...n/src/rules/no-non-null-asserted-optional-chain.ts	`41.93% <21.73%> (-50.93%)`	⬇️
...s/eslint-plugin/src/rules/prefer-optional-chain.ts	`94.23% <100.00%> (+0.05%)`	⬆️
packages/typescript-estree/src/convert.ts	`98.37% <100.00%> (+0.01%)`	⬆️
packages/typescript-estree/src/node-utils.ts	`97.68% <100.00%> (+0.98%)`	⬆️