I was considering doing a big breaking change an introducing a new AST node in here to represent all tuple members, instead of having all of the following as valid tuple membersTSOptionalType,TSRestType,TSNamedTupleMember, and anyTypeNode.
Whilst it will be a much nicer AST to consume, it's probably too large of a change to make...

This PR also updates the versions of babel we test against, and unignores some tests. Doing so uncovered a range bug inimport type Foo from 'foo' (theImportDefaultSpecifier's range included thetype keyword).

Finally, I also brought over the compile-time checks added in#2375

bradzacher added the ASTPRs and Issues about the AST structure label

Aug 9, 2020

Copy link

Contributor

typescript-eslintbot commentedAug 9, 2020

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

bradzacher mentioned this pull request

Aug 9, 2020

TypeScript 4.0 Syntax Support#2260

Closed

bradzacher force-pushed thets4-labelled-tuple-2 branch from17bcfb2 to9d94a36Compare

August 9, 2020 22:21

bradzacher mentioned this pull request

Aug 9, 2020

Release 2.1 checklistprettier/prettier#8882

Closed

10 tasks

feat(typescript-estree): support TSv4 labelled tuple members

fabf2e0

bradzacher force-pushed thets4-labelled-tuple-2 branch from9d94a36 tofabf2e0Compare

August 9, 2020 22:45

Copy link

codecovbot commentedAug 9, 2020

Codecov Report

Merging#2378 intomaster willincrease coverage by0.00%.
The diff coverage is88.23%.

@@           Coverage Diff           @@##           master    #2378   +/-   ##=======================================  Coverage   93.10%   93.11%           =======================================  Files         285      285             Lines        9125     9134    +9       Branches     2504     2505    +1     =======================================+ Hits         8496     8505    +9  Misses        302      302             Partials      327      327

Flag	Coverage Δ
#unittest	`93.11% <88.23%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...nt-plugin/src/rules/no-unused-vars-experimental.ts	`91.48% <ø> (ø)`
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts	`100.00% <ø> (ø)`
packages/typescript-estree/src/convert.ts	`98.36% <85.71%> (+0.01%)`	⬆️
...ckages/scope-manager/src/referencer/TypeVisitor.ts	`89.55% <100.00%> (+0.15%)`	⬆️
packages/visitor-keys/src/visitor-keys.ts	`100.00% <100.00%> (ø)`