This PR is fixes crashes in no-unused-vars for decorators in non identifier function parameters, and fixes issue with no-shadow forthis in functions

#122 (comment)

i think we should merge this after#234 (snapshots for scope analysis)

fixes:#207

armano2 requested a review fromJamesHenry

February 10, 2019 05:12

armano2 self-assigned this

Feb 10, 2019

armano2 added the bugSomething isn't working label

Feb 10, 2019

armano2 changed the title~~fix(parser): fix visiting decorators in parameters~~fix(parser): fix crash during visiting decorators in parameters

Feb 10, 2019

Copy link

codecovbot commentedFeb 10, 2019•
edited
Loading

Codecov Report

Merging#237 intomaster willincrease coverage by0.07%.
The diff coverage is100%.

@@            Coverage Diff            @@##           master    #237      +/-   ##=========================================+ Coverage   94.53%   94.6%   +0.07%=========================================  Files          63      63                Lines        2761    2762       +1       Branches      718     719       +1     =========================================+ Hits         2610    2613       +3  Misses         57      57+ Partials       94      92       -2

Impacted Files	Coverage Δ
packages/parser/src/visitor-keys.ts	`100% <ø> (ø)`	⬆️
packages/eslint-plugin/src/rules/no-unused-vars.ts	`92.85% <ø> (+4.97%)`	⬆️
packages/parser/src/analyze-scope.ts	`95.76% <100%> (+0.09%)`	⬆️

armano2 changed the title~~fix(parser): fix crash during visiting decorators in parameters~~fix(parser): fix crash when visiting decorators in parameters

Feb 10, 2019

armano2 mentioned this pull request

Feb 11, 2019

feat(parser): Draft of scope analysis with types#233

Closed

8 tasks

fix(parser): fix visiting decorators in parameters

105797e

armano2 removed the request for review fromJamesHenry

February 11, 2019 02:48

armano2 added2 commits

February 11, 2019 03:53

fix(parser): fix rebase conflict

11a2d2e

test(eslint-plugin): remove redundant tests

a62e268

armano2 requested a review frombradzacher

February 11, 2019 03:08

Merge branch 'master' into no-unused-vars

0c3973c

armano2 requested review froma team and removed request forbradzacher

February 11, 2019 18:44

bradzacher approved these changes

Feb 12, 2019

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

don't know a heap about the scope manager yet, but the CI passes and I don't see anything stupid in the code, so I'm happy with it 😄

Copy link

CollaboratorAuthor

armano2 commentedFeb 12, 2019•
edited
Loading

Crash is related to eslint not beeing able to set parent to decorators in parameters.
we was creating references while visiting it with pattern-visitor, but nodes was not traversable.

eslint traverse nodes base on structure defined in visitor-keys, and setts up parent for nodes.

no-unused-vars is relying on parent of nodes set properly

2nd issue was that TSParameterProperty was not visitable and rule itself was reporting unused variables bacause we was not making references for decorators