Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [typedef] remove all defaults#2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intov4fromv4-typedef-defaults
Aug 3, 2020

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedAug 3, 2020•
edited
Loading

BREAKING CHANGE:

Removes all default options fromtypedef. Users will have to specifically opt-in to all options them selves.

This is intentional friction being introduced to setup the rule to help discourage it as it's not recommended for use.
This also ensures this rule cannot conflict with any other rules (or even do anything) in theall config.

Fixes#2075

@bradzacherbradzacher added breaking changeThis change will require a new major version to be released default rule optionsDiscussions about default rule options labelsAug 3, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@bradzacherbradzacher linked an issueAug 3, 2020 that may beclosed by this pull request
@codecov
Copy link

codecovbot commentedAug 3, 2020•
edited
Loading

Codecov Report

Merging#2352 intov4 willdecrease coverage by0.00%.
The diff coverage isn/a.

@@            Coverage Diff             @@##               v4    #2352      +/-   ##==========================================- Coverage   92.97%   92.97%   -0.01%==========================================  Files         285      285                Lines        9014     9013       -1       Branches     2510     2510              ==========================================- Hits         8381     8380       -1  Misses        304      304                Partials      329      329
FlagCoverage Δ
#unittest92.97% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/rules/typedef.ts97.26% <ø> (ø)
packages/eslint-plugin/src/rules/ban-ts-comment.ts95.45% <0.00%> (-0.20%)⬇️

@bradzacherbradzacher merged commit13bd4dd intov4Aug 3, 2020
@bradzacherbradzacher deleted the v4-typedef-defaults branchAugust 3, 2020 17:18
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 3, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be releaseddefault rule optionsDiscussions about default rule options
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[all] conflict
1 participant
@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp