Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [ban-ts-comment] change default forts-expect-error toallow-with-description#2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intov4from2146-ban-types-defaults
Aug 3, 2020

Conversation

bradzacher
Copy link
Member

Fixes#2146

BREAKING CHANGE:

Default rule options is a breaking change.

…rror` to `allow-with-description`Fixes#2146BREAKING CHANGE:Default rule options is a breaking change.
@bradzacherbradzacher added breaking changeThis change will require a new major version to be released default rule optionsDiscussions about default rule options labelsAug 3, 2020
@bradzacherbradzacher added this to the4.0.0 milestoneAug 3, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedAug 3, 2020

Codecov Report

Merging#2351 intov4 willdecrease coverage by0.00%.
The diff coverage isn/a.

@@            Coverage Diff             @@##               v4    #2351      +/-   ##==========================================- Coverage   92.97%   92.97%   -0.01%==========================================  Files         285      285                Lines        9014     9013       -1       Branches     2510     2510              ==========================================- Hits         8381     8380       -1  Misses        304      304                Partials      329      329
FlagCoverage Δ
#unittest92.97% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts95.45% <ø> (-0.20%)⬇️

@bradzacherbradzacher merged commitef85b7b intov4Aug 3, 2020
@bradzacherbradzacher deleted the 2146-ban-types-defaults branchAugust 3, 2020 16:19
@bradzacherbradzacher linked an issueAug 3, 2020 that may beclosed by this pull request
bradzacher added a commit that referenced this pull requestAug 3, 2020
…rror` to `allow-with-description` (#2351)BREAKING CHANGE:Default rule options is a breaking change.Fixes#2146
bradzacher added a commit that referenced this pull requestAug 9, 2020
…rror` to `allow-with-description` (#2351)BREAKING CHANGE:Default rule options is a breaking change.Fixes#2146
bradzacher added a commit that referenced this pull requestAug 10, 2020
…rror` to `allow-with-description` (#2351)BREAKING CHANGE:Default rule options is a breaking change.Fixes#2146
bradzacher added a commit that referenced this pull requestAug 19, 2020
…rror` to `allow-with-description` (#2351)BREAKING CHANGE:Default rule options is a breaking change.Fixes#2146
bradzacher added a commit that referenced this pull requestAug 29, 2020
…rror` to `allow-with-description` (#2351)BREAKING CHANGE:Default rule options is a breaking change.Fixes#2146
bradzacher added a commit that referenced this pull requestAug 29, 2020
…rror` to `allow-with-description` (#2351)BREAKING CHANGE:Default rule options is a breaking change.Fixes#2146
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 3, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be releaseddefault rule optionsDiscussions about default rule options
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

[ban-ts-comment] require comment descriptions by default
1 participant
@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp