Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
test(parser): change tests in parser to scope analysis#234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have definitely read every line of this PR 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I trust you didn't break anything across the ~400k lines
* Add `no-unnecessary-class` rule* Add metadata* ⬆️ eslint-docs
This PR changes what is tested in parser fixture tests, we are doing parsing tests 2 times now in parser and ts-estree (redundant), instead of doing this now we are going to check how result of generated scope.