Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-extra-parens] stop reporting on calling generic functions with one argument and type parameters containing parentheses#2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 2 commits intotypescript-eslint:masterfromcherryblossom000:2314
Jul 27, 2020

Conversation

@cherryblossom000
Copy link
Contributor

Fixes#2314

…ric functions with one argument and type parameters containing parentheses (fixes#2314)
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@cherryblossom000!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedJul 22, 2020•
edited
Loading

Codecov Report

Merging#2319 intomaster willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##           master    #2319   +/-   ##=======================================  Coverage   93.09%   93.09%           =======================================  Files         284      284             Lines        9092     9097    +5       Branches     2495     2499    +4     =======================================+ Hits         8464     8469    +5  Misses        302      302             Partials      326      326
FlagCoverage Δ
#unittest93.09% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ackages/eslint-plugin/src/rules/no-extra-parens.ts96.77% <100.00%> (+0.28%)⬆️

@bradzacherbradzacher added the bugSomething isn't working labelJul 22, 2020
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - thanks!

@bradzacherbradzacher changed the titlefix(eslint-plugin): [no-extra-parens]: stop reporting on calling generic functions with one argument and type parameters containing parenthesesfix(eslint-plugin): [no-extra-parens] stop reporting on calling generic functions with one argument and type parameters containing parenthesesJul 27, 2020
@bradzacherbradzacher merged commit616a841 intotypescript-eslint:masterJul 27, 2020
@cherryblossom000cherryblossom000 deleted the 2314 branchJuly 27, 2020 22:36
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 27, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[no-extra-parens] False positive when calling generic function with single argument and type parameter with parentheses

2 participants

@cherryblossom000@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp