Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): add 'no-unnecessary-qualifier' rule#231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

uniqueiniquity
Copy link
Contributor

Add equivalent rule to TSLint'sno-unnecessary-qualifier.
This rule requires semantic information.

@codecov
Copy link

codecovbot commentedFeb 8, 2019•
edited
Loading

Codecov Report

Merging#231 intomaster willincrease coverage by<.01%.
The diff coverage is94.54%.

@@            Coverage Diff             @@##           master     #231      +/-   ##==========================================+ Coverage   94.53%   94.53%   +<.01%==========================================  Files          62       63       +1       Lines        2706     2761      +55       Branches      701      718      +17     ==========================================+ Hits         2558     2610      +52  Misses         57       57- Partials       91       94       +3
Impacted FilesCoverage Δ
...slint-plugin/src/rules/no-unnecessary-qualifier.ts94.54% <94.54%> (ø)

@uniqueiniquity
Copy link
ContributorAuthor

Regarding the diff coverage for the function i added toutil.js, it only runs when used with TS 2.5. Do we have a way of testing that?

@armano2
Copy link
Collaborator

we are not supporting typescript2.5

@uniqueiniquity
Copy link
ContributorAuthor

@armano2 Ok, I can take out the back-compat parts.

armano2 reacted with thumbs up emoji

@bradzacher
Copy link
Member

Hey@uniqueiniquity, sorry for the pain, but we just merged a big PR to convert the plugin to typescript.
Please have a look through the source code and migrate your PR to typescript as well.
Let me know if you've got any questions!

@bradzacherbradzacher added BLOCKED: awaiting ts migration enhancement: new plugin ruleNew rule request for eslint-plugin and removed enhancement: new plugin ruleNew rule request for eslint-plugin labelsFeb 11, 2019
@uniqueiniquityuniqueiniquity merged commitcc8f906 intotypescript-eslint:masterFeb 11, 2019
@uniqueiniquityuniqueiniquity deleted the noUnnecQual branchFebruary 11, 2019 21:55
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

@armano2armano2Awaiting requested review from armano2

@JamesHenryJamesHenryAwaiting requested review from JamesHenry

Assignees
No one assigned
Labels
enhancement: new plugin ruleNew rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@uniqueiniquity@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp