I also ran a quick sanity "integration test" by linking@typescript-eslint/parser into a checkout of theeslint repo to ensure that tests were passing fine there.

Fixes#2204

bradzacher added enhancement

New feature or request

breaking changeThis change will require a new major version to be released labels

Jul 19, 2020

Copy link

Contributor

typescript-eslintbot commentedJul 19, 2020

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

bradzacher changed the title~~feat:~~feat: support ESTree optional chaining representation

Jul 19, 2020

bradzacher force-pushed thenew-optional-chain branch from8ba6e1c tof31b792Compare

July 19, 2020 04:45

bradzacher added this to the4.0.0 milestone

Jul 26, 2020

feat: support ESTree optional chaining representation

2411e6f

bradzacher force-pushed thenew-optional-chain branch fromf31b792 to2411e6fCompare

July 26, 2020 23:11

Copy link

codecovbot commentedJul 26, 2020•
edited
Loading

Codecov Report

Merging#2308 intov4 willdecrease coverage by0.04%.
The diff coverage is89.56%.

@@            Coverage Diff             @@##               v4    #2308      +/-   ##==========================================- Coverage   93.09%   93.05%   -0.05%==========================================  Files         284      285       +1       Lines        9097     9109      +12       Branches     2499     2503       +4     ==========================================+ Hits         8469     8476       +7- Misses        302      303       +1- Partials      326      330       +4

Flag	Coverage Δ
#unittest	`93.05% <89.56%> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...gin-internal/src/rules/no-poorly-typed-ts-props.ts	`88.88% <ø> (ø)`
...int-plugin/src/rules/consistent-type-assertions.ts	`86.48% <ø> (ø)`
...es/eslint-plugin/src/rules/no-array-constructor.ts	`100.00% <ø> (ø)`
...nt-plugin/src/rules/no-extra-non-null-assertion.ts	`100.00% <ø> (ø)`
...ges/eslint-plugin/src/rules/no-misused-promises.ts	`100.00% <ø> (ø)`
...ages/eslint-plugin/src/rules/no-require-imports.ts	`100.00% <ø> (ø)`
packages/eslint-plugin/src/rules/no-unsafe-call.ts	`100.00% <ø> (ø)`
packages/eslint-plugin/src/rules/prefer-for-of.ts	`90.14% <ø> (ø)`
...t-plugin/src/rules/prefer-reduce-type-parameter.ts	`100.00% <ø> (ø)`
...int-plugin/src/rules/require-array-sort-compare.ts	`88.23% <ø> (ø)`
... and24 more