Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: split visitor keys into their own package#2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intomasterfromadd-package-visitor-keys
Jun 25, 2020

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedJun 19, 2020•
edited
Loading

As part of the scope analysis work, I want to remove its runtime dependency ontypescript-estree, so it doesn't need to depend ontypescript.

This moves the visitor keys into their own package,@typescript-eslint/visitor-keys.

BASED ON#2229

Must be retargeted before merging

@bradzacherbradzacher added the refactorPRs that refactor code only labelJun 19, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@bradzacherbradzacher added the blocked by another PRPRs which are ready to go but waiting on another PR labelJun 19, 2020
@codecov
Copy link

codecovbot commentedJun 19, 2020•
edited
Loading

Codecov Report

Merging#2230 intomaster willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##           master    #2230   +/-   ##=======================================  Coverage   93.29%   93.29%           =======================================  Files         173      173             Lines        7788     7789    +1       Branches     2284     2284           =======================================+ Hits         7266     7267    +1  Misses        247      247             Partials      275      275
FlagCoverage Δ
#unittest93.29% <100.00%> (+<0.01%)⬆️
Impacted FilesCoverage Δ
packages/typescript-estree/src/simple-traverse.ts95.00% <100.00%> (ø)
packages/visitor-keys/src/visitor-keys.ts100.00% <100.00%> (ø)

@bradzacherbradzacherforce-pushed theadd-package-visitor-keys branch from60444e9 toe199658CompareJune 19, 2020 21:30
@bradzacherbradzacher mentioned this pull requestJun 19, 2020
41 tasks
@bradzacherbradzacherforce-pushed theadd-package-visitor-keys branch frome199658 toe1d94e7CompareJune 25, 2020 00:07
Base automatically changed fromadd-package-types tomasterJune 25, 2020 00:19
As part of the scope analysis work, I want to remove its runtime dependency on `typescript-estree`, so it doesn't need to depend on `typescript`.This moves the visitor keys into their own package.
@bradzacherbradzacherforce-pushed theadd-package-visitor-keys branch frome1d94e7 tod0235aaCompareJune 25, 2020 00:21
@bradzacherbradzacher merged commit689dae3 intomasterJun 25, 2020
@bradzacherbradzacher deleted the add-package-visitor-keys branchJune 25, 2020 00:30
@bradzacherbradzacher removed the blocked by another PRPRs which are ready to go but waiting on another PR labelJun 25, 2020
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 26, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
refactorPRs that refactor code only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp