Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat: split types into their own package#2229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day. |
codecovbot commentedJun 19, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #2229 +/- ##==========================================- Coverage 93.46% 93.29% -0.17%========================================== Files 174 173 -1 Lines 7953 7788 -165 Branches 2282 2284 +2 ==========================================- Hits 7433 7266 -167- Misses 246 247 +1- Partials 274 275 +1
|
As part of the scope analysis work, I want to remove its runtime dependency on `typescript-estree`, so it doesn't need to depend on `typescript`.It only needs a few pieces from the package; AST_NODE_TYPES, and the visitor keys.This moves the following the to a new package, `@typescript-eslint/types`:- `AST_NODE_TYPES`- `AST_TOKEN_TYPES`- `TSESTree` (aka the types for the typescript-estree AST)- `ParserOptions` (moved out of `experimental-utils`)This has the added bonus of getting us very close to removing the need for `parser` to depend on `experimental-utils`, which will reduce its dependency tree significantly.
Uh oh!
There was an error while loading.Please reload this page.
As part of the scope analysis work, I want to remove its runtime dependency on
typescript-estree, so it doesn't need to depend ontypescript.This moves the following to a new package,
@typescript-eslint/types:AST_NODE_TYPESAST_TOKEN_TYPESTSESTree(aka the types for the typescript-estree AST)ParserOptions(moved out ofexperimental-utils)This has the added bonus of getting us very close to removing the need for
parserto depend onexperimental-utils, which will reduce its dependency tree significantly.