Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat(eslint-plugin): add prefer-function-type rule#222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(eslint-plugin): add prefer-function-type rule#222
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@armano2 /@JamesHenry - why do we "support" Typescript errors out if you try it? |
armano2 commentedFeb 6, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
we errors on them to, if user sets |
you can find a little more info here:#185 (comment) |
if we are going to be able to get semantic errors in "cheap" way without creating program, i'm going to cleanup AST from all invalid nodes, right now prettier expects that we are going to output ast as is, and they can rebuild it without changing functionality only style |
Should this have a different name? Perhaps |
@j-f1 I'm open for naming suggestions. I was just matching TSLint's name, since I don't have a good sense of the ESLint rule naming conventions |
(hint: we don't really have any solid naming conventions yet 😅 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but now that it's been pointed out, I agree the name could be a lot clearer
Code LGMT - change the name and we're good to go |
Apologies for the conflicts, we decided to remove the counts from the ROADMAP here:#225 They are too awkward to maintain manually, so this is the last time you will have to deal with syncing that up! |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome, thanks!
codecovbot commentedFeb 8, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #222 +/- ##==========================================+ Coverage 96.79% 96.83% +0.04%========================================== Files 56 57 +1 Lines 2525 2558 +33 Branches 374 374 ==========================================+ Hits 2444 2477 +33 Misses 42 42 Partials 39 39
|
This PR implements rule [no-misused-new](https://palantir.github.io/tslint/rules/no-misused-new/)
Add rule equivalent to TSLint's 'callable-types'.