Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(experimental-utils): downlevel type declarations for versions older than 3.8#2133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day. |
Codecov Report
@@ Coverage Diff @@## master #2133 +/- ##======================================= Coverage 93.42% 93.42% ======================================= Files 171 171 Lines 7755 7755 Branches 2215 2215 ======================================= Hits 7245 7245 Misses 244 244 Partials 266 266
|
adidahiya commentedJun 1, 2020
TIL about |
Fixes#2114
Use
downlevel-dts
to do it.I thought about just removing the private fields, but I think this is better for ensuring we don't cause regressions going forward.
Also it sets a precedence that I will leverage as part of#1939.