Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(experimental-utils): downlevel type declarations for versions older than 3.8#2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intomasterfromdownlevel-dts
May 30, 2020

Conversation

bradzacher
Copy link
Member

Fixes#2114

Usedownlevel-dts to do it.
I thought about just removing the private fields, but I think this is better for ensuring we don't cause regressions going forward.

Also it sets a precedence that I will leverage as part of#1939.

Etheryte reacted with thumbs up emoji
@bradzacherbradzacher added the bugSomething isn't working labelMay 30, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedMay 30, 2020

Codecov Report

Merging#2133 intomaster willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master    #2133   +/-   ##=======================================  Coverage   93.42%   93.42%           =======================================  Files         171      171             Lines        7755     7755             Branches     2215     2215           =======================================  Hits         7245     7245             Misses        244      244             Partials      266      266
FlagCoverage Δ
#unittest93.42% <ø> (ø)

@bradzacherbradzacher merged commit7925823 intomasterMay 30, 2020
@bradzacherbradzacher deleted the downlevel-dts branchMay 30, 2020 21:54
@adidahiya
Copy link

TIL aboutdownlevel-dts. neat!

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 2, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

experimental-utils v3.0 requires TS 3.8 compiler and ES2015 target
2 participants
@bradzacher@adidahiya

[8]ページ先頭

©2009-2025 Movatter.jp