Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): fix crash in no-unnecessary-type-assertion#212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix(eslint-plugin): fix crash in no-unnecessary-type-assertion#212
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Codecov Report
@@ Coverage Diff @@## master #212 +/- ##==========================================+ Coverage 96.37% 96.37% +<.01%========================================== Files 51 51 Lines 2455 2457 +2 Branches 370 370 ==========================================+ Hits 2366 2368 +2 Misses 46 46 Partials 43 43
|
This seems representative of a parse/conversion error. I’m fine with this as a fix but I want to take a look at your test cases and figure out what’s going wrong. |
@uniqueiniquity i tried to setup this rule inside this project and i got a lot of false-positives with Syntax has no type in this case |
@uniqueiniquity Shall I wait to approve this so that you can look into it? I imagine that will make it easier to track? |
@JamesHenry looking now |
@armano2@JamesHenry I've addressed the issue in in#226; it was an issue in convert after all :) |
…pescript-eslint#227)- correct url in no-misused-new- add tslint addontation to no-namespace- enable rules: eslint-plugin/no-deprecated-context-methods, eslint-plugin/prefer-output-nullfixes:typescript-eslint#213fixes:typescript-eslint#212
Uh oh!
There was an error while loading.Please reload this page.
Rule crashes when i try to use it in this project