Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(ts-estree): convert decorators on var and fn decs#211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 3 commits intomasterfromdodgy-decorators
Feb 7, 2019

Conversation

JamesHenry
Copy link
Member

@JamesHenryJamesHenry commentedFeb 5, 2019•
edited
Loading

fixes#185

I've used the same comment we used in other places, such as interfaces and enums

armano2
armano2 previously approved these changesFeb 5, 2019
Copy link
Collaborator

@armano2armano2 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, just regenerate tests for parser

@codecov
Copy link

codecovbot commentedFeb 7, 2019

Codecov Report

Merging#211 intomaster willincrease coverage by<.01%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #211      +/-   ##==========================================+ Coverage   96.76%   96.77%   +<.01%==========================================  Files          53       53                Lines        2472     2478       +6       Branches      370      372       +2     ==========================================+ Hits         2392     2398       +6  Misses         40       40                Partials       40       40
Impacted FilesCoverage Δ
packages/typescript-estree/src/convert.ts97.6% <100%> (+0.02%)⬆️

@JamesHenryJamesHenry merged commit0a1777f intomasterFeb 7, 2019
@JamesHenryJamesHenry deleted the dodgy-decorators branchFebruary 7, 2019 02:04
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull requestAug 27, 2019
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@armano2armano2armano2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw errors for non-class decorators
2 participants
@JamesHenry@armano2
[8]ページ先頭
©2009-2025 Movatter.jp