Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [ban-ts-comments] add "allow-with-description" option#2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@dimitropoulos
Copy link
Contributor

closes#2093

ota-meshi reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@dimitropoulos!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@dimitropoulosdimitropoulos changed the titleadds "allow-with-description" option toban-ts-comments rulefeat: adds "allow-with-description" option toban-ts-comments ruleMay 25, 2020
@codecov
Copy link

codecovbot commentedMay 25, 2020•
edited
Loading

Codecov Report

Merging#2099 intomaster willdecrease coverage by0.00%.
The diff coverage is90.90%.

@@            Coverage Diff             @@##           master    #2099      +/-   ##==========================================- Coverage   93.42%   93.41%   -0.01%==========================================  Files         171      171                Lines        7755     7763       +8       Branches     2215     2219       +4     ==========================================+ Hits         7245     7252       +7- Misses        244      245       +1  Partials      266      266
FlagCoverage Δ
#unittest93.41% <90.90%> (-0.01%)⬇️
Impacted FilesCoverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts95.65% <90.90%> (-4.35%)⬇️

@dimitropoulos
Copy link
ContributorAuthor

once this merges, I'm happy to do a follow-up PR where I change the default (since that will have to wait in the PR until 4.0 happens)

@dimitropoulosdimitropoulos changed the titlefeat: adds "allow-with-description" option toban-ts-comments rulefeat(eslint-plugin): adds "allow-with-description" option toban-ts-comments ruleMay 25, 2020
@bradzacherbradzacher added the enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule labelMay 25, 2020
@bradzacherbradzacher changed the titlefeat(eslint-plugin): adds "allow-with-description" option toban-ts-comments rulefeat(eslint-plugin): [ban-ts-comments] add "allow-with-description" optionMay 25, 2020
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

pretty straightforward! Thanks for doing this
A few comments

@bradzacherbradzacher added the awaiting responseIssues waiting for a reply from the OP or another party labelMay 26, 2020
@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelMay 27, 2020
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - thanks for your work!

dimitropoulos reacted with rocket emoji
@bradzacherbradzacher merged commit8a0fd18 intotypescript-eslint:masterMay 30, 2020
@dimitropoulosdimitropoulos deleted the ts-comment-description branchMay 31, 2020 02:21
@dimitropoulos
Copy link
ContributorAuthor

great!@bradzacher would now(ish) be a good time to make the (breaking change) PR that sets this option on by default for whenever 4.0 happens?

@bradzacher
Copy link
Member

I think just raise an issue for now, we can tag it and create a milestone to track 4.0 like we did for 3.0. Saves having a PR open for months to rebase :)

Copy link

@isilherisilher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cool! I'm going to add that shiny newallow-with-description setting 🤩

dimitropoulos reacted with thumbs up emojidimitropoulos reacted with heart emoji
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

+1 more reviewer

@isilherisilherisilher left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ban-ts-comment] add option to allow a ts-comment if there is a description with it

3 participants

@dimitropoulos@bradzacher@isilher
[8]ページ先頭
©2009-2025 Movatter.jp