Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor(parser): add ast types to parser#205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 16 commits intotypescript-eslint:masterfromarmano2:parser-types
Feb 7, 2019
Merged

refactor(parser): add ast types to parser#205

JamesHenry merged 16 commits intotypescript-eslint:masterfromarmano2:parser-types
Feb 7, 2019

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedFeb 4, 2019•
edited
Loading

No description provided.

@codecov
Copy link

codecovbot commentedFeb 4, 2019•
edited
Loading

Codecov Report

Merging#205 intomaster willincrease coverage by0.08%.
The diff coverage is99.39%.

@@            Coverage Diff             @@##           master     #205      +/-   ##==========================================+ Coverage   96.57%   96.66%   +0.08%==========================================  Files          51       52       +1       Lines        2455     2459       +4       Branches      370      370              ==========================================+ Hits         2371     2377       +6+ Misses         42       41       -1+ Partials       42       41       -1
Impacted FilesCoverage Δ
packages/eslint-plugin-tslint/src/index.ts90% <ø> (ø)⬆️
packages/parser/src/parser.ts100% <ø> (ø)⬆️
packages/typescript-estree/src/ts-estree.ts100% <100%> (ø)
packages/typescript-estree/src/node-utils.ts95.36% <100%> (ø)⬆️
packages/typescript-estree/src/convert.ts97.27% <100%> (ø)⬆️
packages/typescript-estree/src/parser.ts93.1% <100%> (+0.12%)⬆️
packages/typescript-estree/src/convert-comments.ts96% <100%> (ø)⬆️
packages/parser/src/analyze-scope.ts95.66% <87.5%> (+0.78%)⬆️

@@ -214,7 +220,7 @@ class Referencer extends OriginalReferencer {
this.visit(node.superTypeParameters);
}
if (node.implements) {
this.visit(node.implements);
node.implements.forEach(this.visit, this);
Copy link
CollaboratorAuthor

@armano2armano2Feb 4, 2019•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this is actual issue,implements in classes is a array of nodes butvisit expect that you provide node iteslf

i have to design a way to test visiting
scope analysis snapshots does not contain information about implements, its part of "type scope", and its not yet implemented

see#19

@armano2armano2 added the DO NOT MERGEPRs which should not be merged yet labelFeb 4, 2019
@armano2armano2 removed the DO NOT MERGEPRs which should not be merged yet labelFeb 4, 2019
@armano2armano2 removed the request for review frombradzacherFebruary 4, 2019 22:08
@armano2armano2 self-assigned thisFeb 5, 2019
@armano2armano2 requested review fromJamesHenry and removed request forJamesHenryFebruary 5, 2019 03:44
@armano2armano2 added blocked by another PRPRs which are ready to go but waiting on another PR and removed blocked by another PRPRs which are ready to go but waiting on another PR labelsFeb 5, 2019
@bradzacher
Copy link
Member

let me know when this is in a state you'd like a review!

@armano2
Copy link
CollaboratorAuthor

armano2 commentedFeb 6, 2019•
edited
Loading

i aligned it with your changes toeslint-plugin, and its ready

bradzacher reacted with thumbs up emoji

@JamesHenry
Copy link
Member

JamesHenry commentedFeb 6, 2019 via email

You need to do the rename in each file though, you are creating multiplenames symbols for the same thing in different places.With my suggestion you could do the same refactor step on one single symbolwhich would be imported by name everywhere
…
On Tue, 5 Feb 2019 at 20:58, Armano ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/typescript-estree/src/parser.ts <#205 (comment)> : > @@ -14,8 +14,8 @@ import ts from 'typescript'; import convert from './ast-converter'; import { convertError } from './convert'; import { firstDefined } from './node-utils'; -import * as es from './typedefs'; -import { Extra, ParserOptions } from './parser-options'; +import * as TSESTree from './typedefs'; i renames all es to TSEStree, i'm unsure what editor you are using but in Intelij its right click -> refactor -> rename -> and its done xd — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#205 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA29qxqPtTRd3syWAUQ5W4whnPBntm9Xks5vKjbegaJpZM4agcOV> .

@JamesHenry
Copy link
Member

^ Whoops added the above comment via email and it didn’t link it to your comment above

@JamesHenryJamesHenry merged commit7cd3bc2 intotypescript-eslint:masterFeb 7, 2019
@armano2armano2 deleted the parser-types branchFebruary 7, 2019 01:27
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher left review comments

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees

@armano2armano2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@armano2@bradzacher@JamesHenry
[8]ページ先頭
©2009-2025 Movatter.jp