Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): added new rule unbound-method#204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

Adds the equivalent of TSLint'sno-unbound-method rule.

Josh Goldberg added2 commitsFebruary 3, 2019 16:57
Adds the equivalent of TSLint's `no-unbound-method` rule.
@codecov
Copy link

codecovbot commentedFeb 3, 2019•
edited
Loading

Codecov Report

Merging#204 intomaster willdecrease coverage by<.01%.
The diff coverage is96.29%.

@@            Coverage Diff             @@##           master     #204      +/-   ##==========================================- Coverage    97.2%   97.19%   -0.01%==========================================  Files          68       69       +1       Lines        2507     2534      +27       Branches      388      392       +4     ==========================================+ Hits         2437     2463      +26  Misses         44       44- Partials       26       27       +1
Impacted FilesCoverage Δ
packages/eslint-plugin/src/rules/unbound-method.ts96.29% <96.29%> (ø)

@armano2armano2 added the enhancement: new plugin ruleNew rule request for eslint-plugin labelFeb 4, 2019
Copy link
Member

@JamesHenryJamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice job overall, just the one weird typo

JamesHenry
JamesHenry previously approved these changesFeb 7, 2019
bradzacher
bradzacher previously approved these changesFeb 7, 2019
@JamesHenry
Copy link
Member

Apologies for the conflicts, we decided to remove the counts from the ROADMAP here:#225

They are too awkward to maintain manually, so this is the last time you will have to deal with syncing that up!

JoshuaKGoldberg reacted with hooray emoji

@bradzacherbradzacher dismissed stale reviews fromJamesHenry and themself via30035e8February 7, 2019 03:47
bradzacher
bradzacher previously approved these changesFeb 7, 2019
JamesHenry
JamesHenry previously approved these changesFeb 7, 2019
@bradzacher
Copy link
Member

Hey@JoshuaKGoldberg, sorry for the pain, but we just merged a big PR to convert the plugin to typescript.
Please have a look through the source code and migrate your PR to typescript as well.
Let me know if you've got any questions!

@bradzacherbradzacher dismissed stale reviews fromJamesHenry and themselfFebruary 11, 2019 18:08

needs ts conversion

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat(eslint-plugin): added new rule no-unbound-methodfeat(eslint-plugin): added new rule unbound-methodFeb 18, 2019
@JoshuaKGoldberg
Copy link
MemberAuthor

Whoohoo, TypeScript conversion! Absolutely more than worth the PR churn. 😄

Well, the build looks like it partially failed from DevOpsflickering for a moment. Linting and formatting passes locally.

I'll try to get to the other PRs soon!™

armano2 reacted with thumbs up emoji

JamesHenry
JamesHenry previously requested changesFeb 23, 2019
@JoshuaKGoldberg
Copy link
MemberAuthor

Ping@j-f1(since you commented most recently) - is there anything I'm being waited on for this?

bradzacher
bradzacher previously approved these changesMar 13, 2019
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

JoshuaKGoldberg reacted with heart emoji
@JoshuaKGoldberg
Copy link
MemberAuthor

👋@bradzacher is there something that needs to be done? I'd very much like to help migrate more rules from tslint to typescript-eslint but this and my other two PRs have been sitting for a while. 😢

@JamesHenry
Copy link
Member

JamesHenry commentedApr 3, 2019•
edited
Loading

Sorry for the slow process on some of your PRs@JoshuaKGoldberg - as soon as the merge conflicts are resolved, we'll get this in!

JoshuaKGoldberg reacted with hooray emoji

JamesHenry
JamesHenry previously approved these changesApr 3, 2019
@JamesHenryJamesHenry merged commit6718906 intotypescript-eslint:masterApr 3, 2019
@JamesHenry
Copy link
Member

Thanks again,@JoshuaKGoldberg!

@JoshuaKGoldbergJoshuaKGoldberg deleted the typescript-eslint-no-unbound-method branchApril 3, 2019 18:47
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull requestAug 27, 2019
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@sindresorhussindresorhussindresorhus left review comments

@mysticateamysticateamysticatea left review comments

@j-f1j-f1j-f1 left review comments

@JamesHenryJamesHenryJamesHenry approved these changes

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
enhancement: new plugin ruleNew rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@JoshuaKGoldberg@JamesHenry@bradzacher@sindresorhus@mysticatea@j-f1@armano2
[8]ページ先頭
©2009-2025 Movatter.jp