Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: consume new scope analysis package#2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intov4fromconsume-new-scope-analysis
Jul 28, 2020

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedMay 18, 2020
edited
Loading

Fixes#1856

  • switchparser to usescope-manager
    • I was able to delete almost all of the snapshots fromparser, because they were (pretty useless and unreviewed) snapshots of the scope tree from every singleshared-fixture.
  • Fix up rules:
    • no-unused-vars
      • this exposedso many bugs in the tests themselves - so many unused generic type parameters (function foo<T>() {} andclass Foo<T> {}).
    • no-undef
    • no-shadow
      • define an extension rule to handlethis arg shadowing, and add an option for ignoring type/value shadowing.
    • no-redeclare
      • define an extension rule to handle function overloads
    • no-use-before-define

BASED ON#1939

BREAKING

This is a big change that will require action from users in the form of:

  • configuring new rules,
  • reconfiguring old rules,
  • handling numerous new reports due to better (correct) coverage,
  • (in some cases) adding theparserOptions.lib to silence some false-positives.

We're going to have to do a 4.0 release v soon due to the optional chain and class property AST changes, so we can hold off on this until then

@bradzacherbradzacher added enhancementNew feature or request blocked by another PRPRs which are ready to go but waiting on another PR labelsMay 18, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch 2 times, most recently from667bdf2 tob3ccb87CompareMay 23, 2020 23:51
@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch fromb3ccb87 to1a7a664CompareMay 24, 2020 01:35
@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch from1a7a664 to72a8b1aCompareMay 24, 2020 04:27
@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch from72a8b1a to582e7e2CompareJune 1, 2020 01:07
@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch from582e7e2 to07a426aCompareJune 19, 2020 19:08
@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch 4 times, most recently froma5c53df toe0b1d0eCompareJune 20, 2020 00:51
@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch frome0b1d0e tod656e37CompareJune 21, 2020 04:10
@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch fromd656e37 tod7a35ddCompareJune 25, 2020 00:12
@bradzacherbradzacherforce-pushed thescope-analysis branch 2 times, most recently from5c3398f tof0ec7daCompareJune 27, 2020 22:06
@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch 4 times, most recently from517de6c tofbe16acCompareJune 28, 2020 20:31
@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch 5 times, most recently fromf475b2b tob7c5f78CompareJune 29, 2020 08:43
@codecov
Copy link

codecovbot commentedJun 29, 2020
edited
Loading

Codecov Report

Merging#2039 intov4 willdecrease coverage by0.07%.
The diff coverage is92.30%.

@@            Coverage Diff             @@##               v4    #2039      +/-   ##==========================================- Coverage   93.05%   92.97%   -0.08%==========================================  Files         285      285                Lines        9109     9014      -95       Branches     2503     2510       +7     ==========================================- Hits         8476     8381      -95- Misses        303      304       +1+ Partials      330      329       -1
FlagCoverage Δ
#unittest92.97% <92.30%> (-0.08%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/configs/all.ts100.00% <ø> (ø)
...ages/eslint-plugin/src/rules/no-empty-interface.ts95.83% <0.00%> (-0.33%)⬇️
...nt-plugin/src/rules/no-unused-vars-experimental.ts91.48% <ø> (ø)
packages/experimental-utils/src/ts-eslint/Scope.ts100.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-redeclare.ts87.17% <87.17%> (ø)
...es/eslint-plugin/src/rules/no-use-before-define.ts94.36% <87.50%> (-2.78%)⬇️
packages/eslint-plugin/src/rules/no-unused-vars.ts96.87% <96.00%> (+4.01%)⬆️
packages/eslint-plugin/src/rules/no-shadow.ts98.41% <98.41%> (ø)
... and1 more

Base automatically changed fromscope-analysis tomasterJune 29, 2020 08:53
@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch fromb7c5f78 toa65330fCompareJune 29, 2020 08:55
@bradzacherbradzacher added breaking changeThis change will require a new major version to be released and removed blocked by another PRPRs which are ready to go but waiting on another PR labelsJun 29, 2020
@bradzacherbradzacher marked this pull request as ready for reviewJuly 10, 2020 17:37
@bradzacherbradzacher changed the base branch frommaster tov4July 27, 2020 14:19
@bradzacherbradzacherforce-pushed theconsume-new-scope-analysis branch froma65330f tobb26959CompareJuly 28, 2020 00:44
@bradzacherbradzacher merged commitabb0617 intov4Jul 28, 2020
@bradzacherbradzacher deleted the consume-new-scope-analysis branchJuly 28, 2020 01:07
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 28, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be releasedenhancementNew feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[meta] Problems with the rules that use scope analysis [no-unused-vars][no-undef][no-shadow][no-redeclare][no-use-before-define]
1 participant
@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp