Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(experimental-utils): upgrade eslint types for v7#2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intov3fromv3-eslint-v7-types
May 14, 2020

Conversation

bradzacher
Copy link
Member

BREAKING CHANGE:

  • Renames some interfaces to be closer to the underlying ESLint definitions.
  • Changes the definitions to usedeclare class instead of interface types so they're a little more sane.
  • Marks a lot of properties as readonly
    • some because it's correct (eg context and source code)
    • some because it makes some things easier
  • Removed types for APIs that have been deprecated.
    • Some had been deprecated for 3 major versions - it's time to move on.
  • Removed deprecated parser options.

Added a lot of jsdoc to the types. Like a lot. Some taken from eslint's site, some taken from the source code.

BREAKING CHANGE:- Renames some interfaces to be closer to the underlying ESLint definitions.- Changes the definitions to use `declare class` instead of interface types so they're a little more sane.- Marks a lot of properties as readonly  - some because it's correct (eg context and source code)  - some because it makes some things easier- Removed types for APIs that have been deprecated.  - Some had been deprecated for 3 major versions - it's time to move on.- Removed deprecated parser options.Added a lot of jsdoc to the types. Like a lot. Some taken from eslint's site, some taken from the source code.
@bradzacherbradzacher added the enhancementNew feature or request labelMay 14, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@bradzacherbradzacher added this to the3.0.0 milestoneMay 14, 2020
@codecov
Copy link

codecovbot commentedMay 14, 2020

Codecov Report

Merging#2023 intov3 willdecrease coverage by0.00%.
The diff coverage is31.57%.

@@            Coverage Diff             @@##               v3    #2023      +/-   ##==========================================- Coverage   93.61%   93.61%   -0.01%==========================================  Files         169      170       +1       Lines        7680     7679       -1       Branches     2195     2193       -2     ==========================================- Hits         7190     7189       -1  Misses        231      231                Partials      259      259
FlagCoverage Δ
#unittest93.61% <31.57%> (-0.01%)⬇️
Impacted FilesCoverage Δ
...n/src/rules/indent-new-do-not-use/OffsetStorage.ts100.00% <ø> (ø)
packages/eslint-plugin/src/util/misc.ts92.59% <ø> (ø)
...experimental-utils/src/eslint-utils/RuleCreator.ts66.66% <ø> (ø)
...ages/experimental-utils/src/ts-eslint/CLIEngine.ts0.00% <ø> (ø)
...ackages/experimental-utils/src/ts-eslint/ESLint.ts0.00% <0.00%> (ø)
...ackages/experimental-utils/src/ts-eslint/Linter.ts100.00% <ø> (ø)
...ges/experimental-utils/src/ts-eslint/RuleTester.ts100.00% <ø> (+71.42%)⬆️
...ges/experimental-utils/src/ts-eslint/SourceCode.ts100.00% <ø> (ø)
.../experimental-utils/src/eslint-utils/RuleTester.ts8.88% <8.33%> (-0.87%)⬇️
packages/eslint-plugin/src/rules/array-type.ts94.28% <100.00%> (ø)
... and5 more

@bradzacherbradzacher merged commita8b8a6c intov3May 14, 2020
@bradzacherbradzacher deleted the v3-eslint-v7-types branchMay 14, 2020 08:16
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 14, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

1 participant
@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp