feat(eslint-plugin): update recommended sets#2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intov3fromv3-recommended-sets

May 10, 2020

Merged

feat(eslint-plugin): update recommended sets#2001

bradzacher merged 1 commit intov3fromv3-recommended-sets

May 10, 2020

Conversation

Copy link

Member

bradzacher commentedMay 10, 2020

BREAKING CHANGE:

Fixes#1423

feat(eslint-plugin): update recommended sets

42ba0cd

bradzacher added breaking change

This change will require a new major version to be released

recommended-rulesDiscussion about recommended rule sets labels

May 10, 2020

bradzacher added this to the3.0.0 milestone

May 10, 2020

Copy link

Contributor

typescript-eslintbot commentedMay 10, 2020

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

bradzacher linked an issue

May 10, 2020

that may beclosed by this pull request

Changes to therecommended sets for 3.0.0#1423

Closed

Copy link

codecovbot commentedMay 10, 2020

Codecov Report

Merging#2001 intov3 willincrease coverage by0.00%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##               v3    #2001   +/-   ##=======================================  Coverage   93.74%   93.74%           =======================================  Files         172      176    +4       Lines        7813     7817    +4       Branches     2245     2245           =======================================+ Hits         7324     7328    +4  Misses        228      228             Partials      261      261

Flag	Coverage Δ
#unittest	`93.74% <100.00%> (+<0.01%)`	⬆️

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts	`100.00% <ø> (ø)`
packages/eslint-plugin/src/rules/ban-ts-ignore.ts	`100.00% <ø> (ø)`
packages/eslint-plugin/src/rules/camelcase.ts	`92.85% <ø> (ø)`
...kages/eslint-plugin/src/rules/class-name-casing.ts	`100.00% <ø> (ø)`
...int-plugin/src/rules/consistent-type-assertions.ts	`86.48% <ø> (ø)`
...-plugin/src/rules/explicit-function-return-type.ts	`100.00% <ø> (ø)`
...plugin/src/rules/explicit-module-boundary-types.ts	`82.60% <ø> (ø)`
...s/eslint-plugin/src/rules/interface-name-prefix.ts	`100.00% <ø> (ø)`
.../eslint-plugin/src/rules/member-delimiter-style.ts	`94.44% <ø> (ø)`
...kages/eslint-plugin/src/rules/naming-convention.ts	`88.51% <ø> (ø)`
... and25 more