Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): add new rule no-require-imports#199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

lukyth
Copy link
Contributor

Adds the equivalent of TSLint'sno-require-imports rule.

@codecov
Copy link

codecovbot commentedFeb 3, 2019•
edited
Loading

Codecov Report

Merging#199 intomaster willincrease coverage by<.01%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #199      +/-   ##==========================================+ Coverage   96.78%   96.78%   +<.01%==========================================  Files          55       56       +1       Lines        2516     2522       +6       Branches      372      372              ==========================================+ Hits         2435     2441       +6  Misses         42       42                Partials       39       39
Impacted FilesCoverage Δ
...ages/eslint-plugin/lib/rules/no-require-imports.js100% <100%> (ø)

@lukythlukythforce-pushed thelukyth/new-rule-no-require-imports branch from10f3bc8 to7ea0f4dCompareFebruary 4, 2019 01:49
@lukythlukythforce-pushed thelukyth/new-rule-no-require-imports branch from7ea0f4d to1de278fCompareFebruary 4, 2019 01:54
@lukyth
Copy link
ContributorAuthor

@bradzacher Thank you for your review :) I've addressed all the comments. Could you please check it out?

@armano2armano2 added the enhancement: new plugin ruleNew rule request for eslint-plugin labelFeb 4, 2019
bradzacher
bradzacher previously approved these changesFeb 4, 2019
@j-f1
Copy link
Contributor

j-f1 commentedFeb 4, 2019

Just thinking — would this be better suited as a rule ineslint-plugin-import?

mysticatea reacted with thumbs up emojisindresorhus reacted with thumbs down emoji

@lukyth
Copy link
ContributorAuthor

Not sure what's best here. I can try moving this over toeslint-plugin-import if you think it's more appropriate.

@sindresorhus
Copy link

I think the rule should stay here.eslint-plugin-import is not very actively maintained and it also doesn't currently have any rules that target TypeScript.

@JamesHenry
Copy link
Member

Apologies for the conflicts, we decided to remove the counts from the ROADMAP here:#225

They are too awkward to maintain manually, so this is the last time you will have to deal with syncing that up!

lukyth reacted with heart emoji

@JamesHenryJamesHenry merged commit683e5bc intotypescript-eslint:masterFeb 7, 2019
@lukythlukyth deleted the lukyth/new-rule-no-require-imports branchFebruary 7, 2019 15:52
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull requestAug 27, 2019
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@armano2armano2armano2 approved these changes

@JamesHenryJamesHenryJamesHenry approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: new plugin ruleNew rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@lukyth@j-f1@sindresorhus@JamesHenry@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp