Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): added new rule promise-function-async#194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

Adds the equivalent of TSLint'spromise-function-async rule.

Adds the equivalent of TSLint's `promise-function-async` rule.
@codecov
Copy link

codecovbot commentedFeb 3, 2019•
edited
Loading

Codecov Report

Merging#194 intomaster willdecrease coverage by0.07%.
The diff coverage is92.1%.

@@            Coverage Diff             @@##           master     #194      +/-   ##==========================================- Coverage   96.85%   96.78%   -0.08%==========================================  Files          53       55       +2       Lines        2478     2516      +38       Branches      372      372              ==========================================+ Hits         2400     2435      +35- Misses         39       42       +3  Partials       39       39
Impacted FilesCoverage Δ
.../eslint-plugin/lib/rules/promise-function-async.js100% <100%> (ø)
packages/eslint-plugin/lib/utils/types.js78.57% <78.57%> (ø)

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat: (eslint-plugin) added new rule await-promisefeat: (eslint-plugin) added new rule promise-function-asyncFeb 3, 2019
@armano2armano2 changed the titlefeat: (eslint-plugin) added new rule promise-function-asyncfeat(eslint-plugin): added new rule promise-function-asyncFeb 3, 2019
@armano2armano2 added the enhancement: new plugin ruleNew rule request for eslint-plugin labelFeb 3, 2019
bradzacher
bradzacher previously approved these changesFeb 5, 2019
JamesHenry
JamesHenry previously approved these changesFeb 6, 2019
@JamesHenry
Copy link
Member

Apologies for the conflicts, we decided to remove the counts from the ROADMAP here:#225

They are too awkward to maintain manually, so this is the last time you will have to deal with syncing that up!

@bradzacherbradzacher dismissed stale reviews fromJamesHenry and themself via131a158February 7, 2019 03:47
@JamesHenryJamesHenry merged commit5f3aec9 intotypescript-eslint:masterFeb 7, 2019
@JoshuaKGoldbergJoshuaKGoldberg deleted the typescript-eslint-promise-function-async branchFebruary 7, 2019 14:28
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull requestAug 27, 2019
This package now depends directly on typescript-eslint-parser, so no need to do that.
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: new plugin ruleNew rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@JoshuaKGoldberg@JamesHenry@bradzacher@armano2
[8]ページ先頭
©2009-2025 Movatter.jp