Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat: add package scope-manager#1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day. |
895f1a2 to0375ebfComparecodecovbot commentedMay 3, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #1939 +/- ##==========================================- Coverage 93.29% 93.09% -0.20%========================================== Files 173 282 +109 Lines 7789 9014 +1225 Branches 2284 2463 +179 ==========================================+ Hits 7267 8392 +1125- Misses 247 301 +54- Partials 275 321 +46
|
80487d5 todaa415cCompare34a36dc to3c94b99Compare883d48e toa810f23Comparee199658 toe1d94e7Comparee1d94e7 tod0235aaComparead91323 to05b58edCompare
Uh oh!
There was an error while loading.Please reload this page.
Ref#1856
This is an alternate approach to#1533.
Instead of just extending bits and pieces, bring the entire codebase in, clean it up and rebuild it to have native support for TS types.
I found that trying to make the types work was a complete pain because we need a custom typed version of each class anyway.
I figure that we support our own set of JS on top of what
eslint-scopesupports, so it's probably better we maintain the entire stack so we don't do any hacky extension things.We don't want to get into a position where the base package adds handling we weren't expecting.
WIP
eslint-scope,eslint-scopetests,ClassPropertyDecoratorOptionalMemberExpressionOptionalCallExpressionTSAbstractClassPropertyTSAbstractMethodDefinitionTSAsExpressionTSDeclareFunctionTSExportAssignmentTSImportEqualsDeclarationTSInterfaceDeclarationTSMappedTypeTSModuleDeclaration(will need their own scope)TSParameterPropertyTSTypeAliasDeclarationTSTypeAssertionTSTypeParameterTSTypePredicateTSEnumDeclaration(will need their own scope)TSPropertySignatureTSCallSignatureDeclarationTSConstructorTypeTSConstructSignatureDeclarationTSEmptyBodyFunctionExpressionTSFunctionTypeTSMethodSignatureTSIndexSignatureBASED ON#2230
Must be retargeted before merging