Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): createno-invalid-void-type rule#1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 8 commits intotypescript-eslint:masterfromG-Rath:create-invalid-void-rule
Apr 26, 2020
Merged

feat(eslint-plugin): createno-invalid-void-type rule#1847

bradzacher merged 8 commits intotypescript-eslint:masterfromG-Rath:create-invalid-void-rule
Apr 26, 2020

Conversation

G-Rath
Copy link
Contributor

🎉

I think that this might be autofixable by replacingvoid withundefined, but not enough that I'd be willing to place any bets just yet 😬😂

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedApr 4, 2020•
edited
Loading

Codecov Report

Merging#1847 intomaster willincrease coverage by0.01%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##           master    #1847      +/-   ##==========================================+ Coverage   94.36%   94.37%   +0.01%==========================================  Files         166      167       +1       Lines        7608     7629      +21       Branches     2185     2192       +7     ==========================================+ Hits         7179     7200      +21  Misses        183      183                Partials      246      246
FlagCoverage Δ
#unittest94.37% <100.00%> (+0.01%)⬆️
Impacted FilesCoverage Δ
...es/eslint-plugin/src/rules/no-invalid-void-type.ts100.00% <100.00%> (ø)

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not a full review, a few quick nitpicks on the doc.

I think we should name it a little bit clearer than the original rule.
no-invalid-void-type would be better as it:

  • shows it's banning something
  • shows it only applies to the void type, not the operator.

G-Rath reacted with thumbs up emoji
@bradzacherbradzacher added the enhancement: new plugin ruleNew rule request for eslint-plugin labelApr 4, 2020
@G-RathG-Rath changed the titlefeat(eslint-plugin): createinvalid-void rulefeat(eslint-plugin): createno-invalid-void-type ruleApr 12, 2020
@G-RathG-Rath requested a review frombradzacherApril 12, 2020 23:30
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM for the most part.
A few comments.

@bradzacherbradzacher added the awaiting responseIssues waiting for a reply from the OP or another party labelApr 20, 2020
@G-RathG-Rath requested a review frombradzacherApril 23, 2020 05:17
@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelApr 23, 2020
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - thanks!

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: new plugin ruleNew rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@G-Rath@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp