Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs(eslint-plugin): add instructions for using Airbnb's config#177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 5 commits intotypescript-eslint:masterfromaboyton:patch-1
Feb 4, 2019

Conversation

aboyton
Copy link
Contributor

Here's how I've got AIrbnb's style guides working.

Ref#147

j-f1 reacted with thumbs up emoji
@aboytonaboyton mentioned this pull requestFeb 1, 2019
bradzacher
bradzacher previously approved these changesFeb 1, 2019
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

one change otherwise LGTM.

aboyton reacted with thumbs up emoji
Co-Authored-By: aboyton <aboyton@users.noreply.github.com>
@aboytonaboyton dismissed stale reviews frombradzacher viac7c5955February 1, 2019 04:59
j-f1
j-f1 previously approved these changesFeb 2, 2019

Airbnb has two configs, a base one [`eslint-config-airbnb-base`](https://github.com/airbnb/javascript/tree/master/packages/eslint-config-airbnb-base) and one that includes rules for React [`eslint-config-airbnb`](https://github.com/airbnb/javascript/tree/master/packages/eslint-config-airbnb).

First you'll need to install the config acrording to the instructions in one of the links above. `npx install-peerdeps --dev eslint-config-airbnb` or `npx install-peerdeps --dev eslint-config-airbnb-base` should work if you are using **npm 5+**.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

acrording

Typo: should be "according"

Copy link
Member

@JamesHenryJamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Typo already pointed out

@armano2armano2 changed the titleAdd instructions for using Airbnb's configdocs(eslint-plugin): add instructions for using Airbnb's configFeb 3, 2019
@JamesHenryJamesHenry merged commit2e5b46e intotypescript-eslint:masterFeb 4, 2019
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull requestAug 27, 2019
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

@JamesHenryJamesHenryJamesHenry approved these changes

@bradzacherbradzacherbradzacher left review comments

@j-f1j-f1j-f1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@aboyton@JamesHenry@JoshuaKGoldberg@bradzacher@j-f1

[8]ページ先頭

©2009-2025 Movatter.jp