Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): export * regression from 133f622f#1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 2 commits intomasterfrom1746-barrel-export-parse-bug
Mar 18, 2020

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedMar 17, 2020•
edited
Loading

Fixes#1746

133f622 /#1698 introduced a regression.
This was a case I didn't think about in the original implementation.
It's a hole in the types due to the fact that the SyntaxKind enum member, ofc always exists in 3.8.x.

Tested this via:

  • change the resolved typescript version in the root package.json to3.7.5
  • yarn lint - no parsing errors

tom-sherman and ibc reacted with thumbs up emoji
@bradzacherbradzacher added the bugSomething isn't working labelMar 17, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedMar 17, 2020•
edited
Loading

Codecov Report

Merging#1751 intomaster willnot change coverage by%.
The diff coverage is100.00%.

@@           Coverage Diff           @@##           master    #1751   +/-   ##=======================================  Coverage   95.19%   95.19%           =======================================  Files         148      148             Lines        6968     6968             Branches     2009     2009           =======================================  Hits         6633     6633             Misses        124      124             Partials      211      211
FlagCoverage Δ
#unittest95.19% <100.00%> (ø)
Impacted FilesCoverage Δ
packages/typescript-estree/src/convert.ts99.15% <100.00%> (ø)

@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 17, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@existentialismexistentialismexistentialism approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergebugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in 2.24.0: TypeError: Cannot read property 'name' of undefined
2 participants
@bradzacher@existentialism
[8]ページ先頭
©2009-2025 Movatter.jp