feat(typescript-estree): support 3.8`export * as ns`#1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intomasterfrom3-8-export-star-as-ns

Mar 11, 2020

Merged

feat(typescript-estree): support 3.8`export * as ns`#1698

bradzacher merged 1 commit intomasterfrom3-8-export-star-as-ns

Mar 11, 2020

Conversation

Copy link

Member

bradzacher commentedMar 7, 2020•
edited
Loading

~~The ESTree representation is approved, but not yet merged.~~
It's now merged :D
estree/estree#205

bradzacher added enhancement

New feature or request

blocked by another PRPRs which are ready to go but waiting on another PR labels

Mar 7, 2020

Copy link

Contributor

typescript-eslintbot commentedMar 7, 2020

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

armano2 mentioned this pull request

Mar 7, 2020

TypeScript 3.8 Syntax Support#1436

Closed

bradzacher force-pushed the3-8-export-star-as-ns branch froma56005d to9c33d13Compare

March 7, 2020 04:31

bradzacher requested a review fromarmano2

March 7, 2020 04:33

bradzacher changed the base branch frombump-ts-3-8 tomaster

March 9, 2020 01:04

bradzacher force-pushed the3-8-export-star-as-ns branch from9c33d13 toad11fb8Compare

March 9, 2020 01:40

BPScott mentioned this pull request

Mar 9, 2020

Partial support for TypeScript 3.8 (private fields, import/export type modifier)prettier/prettier#7631

Merged

Copy link

codecovbot commentedMar 11, 2020•
edited
Loading

Codecov Report

Merging#1698 intomaster willincrease coverage by0.02%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##           master    #1698      +/-   ##==========================================+ Coverage   95.18%   95.21%   +0.02%==========================================  Files         148      148                Lines        6953     6953                Branches     2005     2006       +1     ==========================================+ Hits         6618     6620       +2+ Misses        124      123       -1+ Partials      211      210       -1