Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(eslint-plugin): add rule no-unsafe-assignment#1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 8 commits intomasterfromno-unsafe-assignment
Apr 9, 2020

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedMar 7, 2020
edited
Loading

See:#791, and the other rules I've added#1643,#1644,#1647

felixfbecker reacted with thumbs up emoji
@bradzacherbradzacher added the enhancement: new plugin ruleNew rule request for eslint-plugin labelMar 7, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedApr 2, 2020
edited
Loading

Codecov Report

Merging#1694 intomaster willdecrease coverage by0.22%.
The diff coverage is80.31%.

@@            Coverage Diff             @@##           master    #1694      +/-   ##==========================================- Coverage   94.64%   94.42%   -0.23%==========================================  Files         160      161       +1       Lines        7263     7386     +123       Branches     2081     2117      +36     ==========================================+ Hits         6874     6974     +100- Misses        167      180      +13- Partials      222      232      +10
FlagCoverage Δ
#unittest94.42% <80.31%> (-0.23%)⬇️
Impacted FilesCoverage Δ
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts80.00% <80.00%> (ø)
packages/eslint-plugin/src/util/types.ts81.01% <83.33%> (+0.74%)⬆️
...ckages/eslint-plugin/src/rules/no-throw-literal.ts95.74% <0.00%> (ø)
...pt-estree/src/create-program/createWatchProgram.ts87.16% <0.00%> (+0.13%)⬆️

@bradzacherbradzacher marked this pull request as ready for reviewApril 7, 2020 05:53
@felixfbecker
Copy link

Is there anything blocking this? Been trying out the otherno-unsafe-* rules (they caught real bugs!) and been missing this case

@bradzacher
Copy link
MemberAuthor

There's nothing blocking it any more. I was going to add an option to prevent "evolving" types, but I decided against that for now (I think it deserves to live as its own rule).

With the CI passing, I'll merge this now.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement: new plugin ruleNew rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New set of rules:no-unsafe-*
2 participants
@bradzacher@felixfbecker

[8]ページ先頭

©2009-2025 Movatter.jp