typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(eslint-plugin): add eslint rule no-useless-constructor#167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JamesHenry merged 9 commits intotypescript-eslint:masterfromarmano2:no-useless-constructor

Feb 1, 2019

Merged

feat(eslint-plugin): add eslint rule no-useless-constructor#167

JamesHenry merged 9 commits intotypescript-eslint:masterfromarmano2:no-useless-constructor

Feb 1, 2019

Conversation

Copy link

Collaborator

armano2 commentedJan 31, 2019

This PR adds wrapper around eslintno-useless-constructor to fix issues from#15 and#48

fixes:#15

armano2 added2 commits

January 31, 2019 02:03

feat(eslint-plugin): add eslint rule no-useless-constructor

5e7c3ff

docs: correct issue id

eeb1dfe

bradzacher reviewed

Jan 31, 2019

View reviewed changes

packages/eslint-plugin/docs/rules/no-useless-constructor.mdShow resolvedHide resolved

packages/eslint-plugin/lib/rules/no-useless-constructor.jsShow resolvedHide resolved

mysticatea reviewed

Jan 31, 2019

View reviewed changes

packages/eslint-plugin/tests/lib/rules/no-useless-constructor.js OutdatedShow resolvedHide resolved

armano2 added4 commits

January 31, 2019 17:00

fix(eslint-plugin): ignore private and protected constructors

f362ecc

fix(eslint-plugin): add additonal test cases and fix formatting

643dfd6

test(eslint-plugin): fix issue in test case

841171c

docs(eslint-plugin): add example of valid ts code

bafe080

bradzacher reviewed

Jan 31, 2019

View reviewed changes

packages/eslint-plugin/lib/rules/no-useless-constructor.js OutdatedShow resolvedHide resolved

armano2 added2 commits

January 31, 2019 19:59

fix(eslint-plugin): improve detection of useless constructors

a06d950

Merge branch 'master' into no-useless-constructor

29d44f4

bradzacher approved these changes

Feb 1, 2019

View reviewed changes

Merge branch 'master' into no-useless-constructor

fbb9586

JamesHenry approved these changes

Feb 1, 2019

View reviewed changes

Copy link

codecovbot commentedFeb 1, 2019

Codecov Report

Merging#167 intomaster willincrease coverage by0.02%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #167      +/-   ##==========================================+ Coverage   95.76%   95.78%   +0.02%==========================================  Files          50       51       +1       Lines        2526     2541      +15       Branches      373      373              ==========================================+ Hits         2419     2434      +15  Misses         63       63                Partials       44       44

Impacted Files	Coverage Δ
.../eslint-plugin/lib/rules/no-useless-constructor.js	`100% <100%> (ø)`

JamesHenry merged commit3fb57a5 intotypescript-eslint:master

Feb 1, 2019

armano2 deleted the no-useless-constructor branch

February 1, 2019 12:48

buschtoens mentioned this pull request

Mar 5, 2019

feat(eslint-plugin): add config all.json#313

Merged

texastoland mentioned this pull request

Mar 7, 2019

[no-useless-constructor] ignores parameter properties#334

Closed

jacobrask mentioned this pull request

Mar 27, 2019

no-useless-constructor crashes: Cannot read property 'body' of nulleslint/eslint#11440

Closed

bradzacher mentioned this pull request

Mar 27, 2019

no-useless-constructor: class declaration with constructor throws exception#15

Closed

kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull request

Aug 27, 2019

[DOCS] Create issue templates (typescript-eslint#167)

f278171

Copy link

tsofist commentedSep 3, 2019

I still have a problem withd.ts file :(

declareclassMySuperClass{constructor(argument1:number);}

Error

TypeError: Cannot read property 'body' of nullOccurred while linting test.d.ts:2    at checkForConstructor (node_modules\eslint\lib\rules\no-useless-constructor.js:169:42)