Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): add rule no-unsafe-member-access#1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intomasterfromno-unsafe-member-access
Mar 3, 2020

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedFeb 26, 2020•
edited
Loading

See#791

I think it's better to introduce these as a number of separate rules.
It makes it easier for people to opt in to the rules, and keeps each implementation small and focused.
This also makes it easier and faster to build and release, as we can build and release smaller rules instead of releasing one monolithic rule.

This rule simply checks all member expressions, and makes sure that you're not chaining a member expression off of anany type.
It inspects the inner-most member expression of a chain to provide the most correct error location.

@bradzacherbradzacher added the enhancement: new plugin ruleNew rule request for eslint-plugin labelFeb 26, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@codecov
Copy link

codecovbot commentedFeb 26, 2020•
edited
Loading

Codecov Report

Merging#1643 intomaster willincrease coverage by0.02%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master    #1643      +/-   ##==========================================+ Coverage   95.35%   95.37%   +0.02%==========================================  Files         145      146       +1       Lines        6804     6836      +32       Branches     1957     1964       +7     ==========================================+ Hits         6488     6520      +32  Misses        111      111                Partials      205      205
Impacted FilesCoverage Δ
...eslint-plugin/src/rules/no-unsafe-member-access.ts100.00% <0.00%> (ø)

@bradzacherbradzacher linked an issueFeb 26, 2020 that may beclosed by this pull request
@bradzacherbradzacherforce-pushed theno-unsafe-member-access branch from05df893 to745b7b3CompareMarch 3, 2020 07:10
@bradzacherbradzacherforce-pushed theno-unsafe-member-access branch from745b7b3 to7e385adCompareMarch 3, 2020 07:56
@bradzacherbradzacher merged commit608a750 intomasterMar 3, 2020
@bradzacherbradzacher deleted the no-unsafe-member-access branchMarch 3, 2020 09:11
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 20, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement: new plugin ruleNew rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New set of rules:no-unsafe-*
1 participant
@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp