Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor(ts-estree): add types to converter#156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
armano2 merged 27 commits intotypescript-eslint:masterfromarmano2:prototype-types-estree
Feb 3, 2019
Merged

refactor(ts-estree): add types to converter#156

armano2 merged 27 commits intotypescript-eslint:masterfromarmano2:prototype-types-estree
Feb 3, 2019

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedJan 28, 2019
edited
Loading

This is prototype of converter with types, with small improvement to performance (this is not goal of this PR).

Changes:

  • type checking of AST structure
  • reduces amount of calls for location data (location is calculated once per node)
  • provides easier way to support range compiler flag (its not supported yet)
  • remove old/unused estree definition files
  • migrates ParserOptions fromtemp-types-based-on-js-source.ts toparser-options.ts
...

before
Complex File:ts-estree x 238 ops/sec ±2.14% (86 runs sampled)
Simple File:ts-estree x 10,706 ops/sec ±3.19% (87 runs sampled)

after
Complex File:ts-estree x 262 ops/sec ±1.78% (84 runs sampled)
Simple File:ts-estree x 11,049 ops/sec ±3.26% (80 runs sampled)

@armano2armano2 added the DO NOT MERGEPRs which should not be merged yet labelJan 28, 2019
@armano2armano2 self-assigned thisJan 28, 2019
@codecov
Copy link

codecovbot commentedJan 28, 2019
edited
Loading

Codecov Report

Merging#156 intomaster willdecrease coverage by0.14%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #156      +/-   ##==========================================- Coverage   95.82%   95.68%   -0.15%==========================================  Files          51       51                Lines        2541     2458      -83       Branches      373      372       -1     ==========================================- Hits         2435     2352      -83- Misses         63       65       +2+ Partials       43       41       -2
Impacted FilesCoverage Δ
packages/typescript-estree/src/tsconfig-parser.ts88.05% <ø> (ø)⬆️
packages/typescript-estree/src/convert.ts94.59% <ø> (-0.57%)⬇️
packages/typescript-estree/src/ast-converter.ts100% <100%> (ø)⬆️
packages/typescript-estree/src/node-utils.ts96.39% <100%> (-0.08%)⬇️
packages/typescript-estree/src/parser.ts91.3% <100%> (ø)⬆️
packages/typescript-estree/src/convert-comments.ts96% <100%> (-0.08%)⬇️

@armano2armano2 requested review froma team and removed request forJamesHenry andbradzacherJanuary 28, 2019 21:52
@armano2armano2 removed the DO NOT MERGEPRs which should not be merged yet labelJan 29, 2019
@bradzacher
Copy link
Member

we should really raise a separate PR to remove all of the JSDoc types from the codebase...

existentialism reacted with thumbs up emojiarmano2 reacted with hooray emoji

@JamesHenry
Copy link
Member

@armano2 On spectrum I believe you said this should wait until after#120 is merged. Is that still the case, or were you referring to something else?

@armano2
Copy link
CollaboratorAuthor

armano2 commentedJan 30, 2019
edited
Loading

both PR adds same file (ast structure), and they are not blocking each other.

On spectrum i was referring to different change :)

@armano2armano2 changed the titlerefactor(ts-estree): prototype of typed converterrefactor(ts-estree): add types to converterJan 31, 2019
@armano2
Copy link
CollaboratorAuthor

@bradzacher@JamesHenry i aligned types (typedefs.ts) from#120

@JamesHenry
Copy link
Member

I manually ran some real-world "benchmarks" by building from this PR and including it in a build of Prettier and running it on a real codebase (angular.io documentation website) and can confirm there are not any performance regressions/issues

@JamesHenry
Copy link
Member

Thanks for all the work on this!

@armano2armano2 merged commit773723b intotypescript-eslint:masterFeb 3, 2019
@armano2armano2 deleted the prototype-types-estree branchFebruary 3, 2019 20:32
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Luckeu pushed a commit to Luckeu/typescript-eslint that referenced this pull requestJun 27, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees

@armano2armano2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@armano2@bradzacher@JamesHenry

[8]ページ先頭

©2009-2025 Movatter.jp