Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): add new rule no-for-in-array#155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

uniqueiniquity
Copy link
Contributor

Adding equivalent of TSLint'sno-for-in-array.

@uniqueiniquity
Copy link
ContributorAuthor

@armano2 How would I test line 38 in the rule? It's not a case that would ever really get hit iftypescript-estree is behaving correctly. Should I just not worry about it?

@armano2
Copy link
Collaborator

hmm, in most cases nodes are present, and i think you should remove this if.

we have cases of nodes not from TS, and "broken" parts of code like
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/typescript-estree/src/convert.ts#L1290

j-f1
j-f1 previously requested changesJan 30, 2019
Copy link
Contributor

@j-f1j-f1 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for contributing! A few small suggestions/questions:

@armano2armano2 added the enhancement: new plugin ruleNew rule request for eslint-plugin labelFeb 3, 2019
@JamesHenry
Copy link
Member

@uniqueiniquity I think the confusion over the .md formatting has been resolved now, things should be easier once this is brought up to date with master

Thanks!

@JamesHenry
Copy link
Member

@j-f1@armano2 Have your concerns been addressed? Please can you update your reviews?

@codecov
Copy link

codecovbot commentedFeb 7, 2019

Codecov Report

Merging#155 intomaster willincrease coverage by0.01%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #155      +/-   ##==========================================+ Coverage   96.75%   96.76%   +0.01%==========================================  Files          52       53       +1       Lines        2462     2472      +10       Branches      370      370              ==========================================+ Hits         2382     2392      +10  Misses         40       40                Partials       40       40
Impacted FilesCoverage Δ
packages/eslint-plugin/lib/util.js97.22% <ø> (ø)⬆️
...ackages/eslint-plugin/lib/rules/no-for-in-array.js100% <100%> (ø)

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@j-f1j-f1j-f1 left review comments

@armano2armano2armano2 approved these changes

@JamesHenryJamesHenryJamesHenry approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: new plugin ruleNew rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@uniqueiniquity@armano2@JamesHenry@bradzacher@j-f1
[8]ページ先頭
©2009-2025 Movatter.jp