Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(parser): Draft of scope analysis with types#1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
armano2 wants to merge12 commits intotypescript-eslint:masterfromarmano2:typed-scopes-v3
Closed

feat(parser): Draft of scope analysis with types#1533

armano2 wants to merge12 commits intotypescript-eslint:masterfromarmano2:typed-scopes-v3

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedJan 28, 2020
edited
Loading

Unfinished and not fully working scope analysis for types.
Original work was started some time ago in#233 and this PR contains all changes rebased to current master

some of changes got migrated outside of this PR to master already and are dropped from here


This is early stage of updated scope-analysis with types included into scope, there is still a lot to do.
Goal of this PR is to solve#18,#19,#21,#60,#207#122,#249,#342,#1542

StrangeWill and tehnrd reacted with hooray emoji
@armano2armano2 added DO NOT MERGEPRs which should not be merged yet scope analyserIssues that are caused by bugs/incomplete cases in the scope analyser labelsJan 28, 2020
@typescript-eslint

This comment has been minimized.

@bradzacher
Copy link
Member

bradzacher commentedJan 29, 2020
edited
Loading

I've never liked this custom scope analyser, because it is a lot of code for us to maintain, and being built on the (poorly documented)eslint-scope really limits its maintenance to... well you.

Does typescript expose any of its scope analysis data? If yes, would it be better to do a conversion pass over this data instead?

Having a quick look, it looks like TS haschecker.getSymbolsInScope(node, SymbolFlags): Symbols[], can we use this?

@bradzacher
Copy link
Member

Closing this in favour of#1939

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 14, 2020
@armano2armano2 deleted the typed-scopes-v3 branchFebruary 13, 2021 15:47
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
DO NOT MERGEPRs which should not be merged yetscope analyserIssues that are caused by bugs/incomplete cases in the scope analyser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@armano2@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp