Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
refactor(ts-estree): simplify calculation of method location#152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
JamesHenry merged 2 commits intotypescript-eslint:masterfromarmano2:function-expression-locJan 27, 2019
Merged
refactor(ts-estree): simplify calculation of method location#152
JamesHenry merged 2 commits intotypescript-eslint:masterfromarmano2:function-expression-locJan 27, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedJan 27, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #152 +/- ##=========================================+ Coverage 95.1% 95.2% +0.09%========================================= Files 49 49 Lines 2493 2480 -13 Branches 373 371 -2 =========================================- Hits 2371 2361 -10+ Misses 73 71 -2+ Partials 49 48 -1
|
JamesHenry approved these changesJan 27, 2019
uniqueiniquity pushed a commit to uniqueiniquity/typescript-eslint that referenced this pull requestJan 28, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
range and location of
FunctionExpressioninMethodDeclaration,SetAccessor,GetAccessorwas calculated in different way, this change unifies this calculation and removes no longer used helper functionfindFirstMatchingToken.we have already test cases for this code, and this change doesn't changes to AST.