Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(eslint-plugin): [naming-convention] allow not check format#1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 3 commits intomasterfromnaming-conventions-patch-1
Jan 14, 2020

Conversation

bradzacher
Copy link
Member

Fixes#1453

Also fixes empty options breaking, because I'm a dingus and didn't ever test this case.

Fixes#1453Also fixes empty options breaking, because I'm a dingus and didn't ever test this case.
@bradzacherbradzacher added bugSomething isn't working enhancement: plugin rule optionNew rule option for an existing eslint-plugin rule labelsJan 14, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link
Collaborator

@armano2armano2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@armano2

This comment has been minimized.

@bradzacher
Copy link
MemberAuthor

yeah I noticed that. It's using the wrong commit to test for some reason..

@bradzacherbradzacher changed the titlefeat(eslint-plugin): [naming-convention] allow not checking formatfeat(eslint-plugin): [naming-convention] allow not check formatJan 14, 2020
@bradzacherbradzacher merged commit61eb434 intomasterJan 14, 2020
@bradzacherbradzacher deleted the naming-conventions-patch-1 branchJanuary 14, 2020 19:58
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 20, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@armano2armano2armano2 approved these changes

Assignees
No one assigned
Labels
bugSomething isn't workingenhancement: plugin rule optionNew rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[naming-convention] How to broaden the format after using the "default" selector
2 participants
@bradzacher@armano2

[8]ページ先頭

©2009-2025 Movatter.jp