Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): add new rule prefer-as-const#1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 12 commits intotypescript-eslint:masterfromarmano2:prefer-as-const
Jan 21, 2020
Merged

feat(eslint-plugin): add new rule prefer-as-const#1431

bradzacher merged 12 commits intotypescript-eslint:masterfromarmano2:prefer-as-const
Jan 21, 2020

Conversation

armano2
Copy link
Collaborator

fixes#312

@armano2armano2 added the package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin labelJan 11, 2020
@armano2armano2 self-assigned thisJan 11, 2020
@typescript-eslint

This comment has been minimized.

@armano2armano2 added the enhancement: new plugin ruleNew rule request for eslint-plugin labelJan 11, 2020
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

two suggestions. otherwise lgtm

@armano2
Copy link
CollaboratorAuthor

as recommended i added 2 optional fixers for variable case

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - thanks!

@bradzacherbradzacher merged commit420db96 intotypescript-eslint:masterJan 21, 2020
@armano2armano2 deleted the prefer-as-const branchJanuary 21, 2020 03:11
mightyiam added a commit to mightyiam/eslint-config-love that referenced this pull requestFeb 4, 2020
BREAKING CHANGE: new rule @typescript-eslint/ban-ts-commenttypescript-eslint/typescript-eslint#1361BREAKING CHANGE: new rule @typescript-eslint/prefer-as-consttypescript-eslint/typescript-eslint#1431Closes#218.
mightyiam added a commit to mightyiam/eslint-config-love that referenced this pull requestFeb 11, 2020
BREAKING CHANGE: new rule @typescript-eslint/prefer-as-consttypescript-eslint/typescript-eslint#1431Closes#218.
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 20, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

@armano2armano2

Labels
enhancement: new plugin ruleNew rule request for eslint-pluginpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: preferas const
2 participants
@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp