Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
chore(ts-estree): draft of estree structure (replacement for ESTreeNode)#137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore(ts-estree): draft of estree structure (replacement for ESTreeNode)#137
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bradzacher commentedJan 25, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I started doing this by hand on my plugin types branch! I was going through each case 1-by-1 and mapping the types together, and mirroring the same names for reusable type groupings that Typescript uses: typescript-eslint/packages/typescript-estree/src/typedefs.ts Lines 45 to 57 in9bfbb86
It's probably better to use these generated types and do a manual pass over |
during generation i'm able to group nodes (i have functionality for this) |
That's awesome! But we'd have to go through the typescript AST to find out all of the reusable type groupings they use, then map those types in ESTree nodes. It's simple to do, but it's far from a trivial thing time-wise, so it's probably better left till after. Anyways, we'd probably want to do a manual pass over these types to triple check they aren't missing anything from our conversion logic in |
this is first step, i have in plans to use types in converter itself this PR is to your branch not to master |
I didn't notice that. Awesome, feel free to merge it in. |
No description provided.