Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): correct type of key for base nodes#1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intotypescript-eslint:masterfromarmano2:fix-ts-estree-types
Dec 21, 2019
Merged

fix(typescript-estree): correct type of key for base nodes#1367

bradzacher merged 1 commit intotypescript-eslint:masterfromarmano2:fix-ts-estree-types
Dec 21, 2019

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedDec 20, 2019•
edited
Loading

This is follow up PR of#1349 that fixes recently introduced invalid key type for base properties

exporttypePropertyName=PropertyNameComputed|PropertyNameNonComputed;

in some places type was defined asPropertyNameComputed | PropertyNameComputed

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@armano2armano2 added bugSomething isn't working package: typescript-estreeIssues related to @typescript-eslint/typescript-estree labelsDec 20, 2019
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oops, thanks for catching this

@bradzacherbradzacher changed the titlefix(ts-estree): correct type of key for base nodesfix(typescript-estree): correct type of key for base nodesDec 21, 2019
@bradzacherbradzacher merged commit099225a intotypescript-eslint:masterDec 21, 2019
@armano2armano2 deleted the fix-ts-estree-types branchDecember 21, 2019 03:51
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 20, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
bugSomething isn't workingpackage: typescript-estreeIssues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp