property names assumed that onlyIdentifier | Literal were valid, when in fact any expression is valid, if and only if the name is computed:{ [1 + 2]: 1 }.

Part of me thinks we should probably split the types to make this nicer (I've raised#1345)

The destructuring types were also inconsistent, so I corrected them.

chore: tighten up destructuring types

bd9ab07

bradzacher added the enhancementNew feature or request label

Dec 18, 2019

Copy link

Contributor

typescript-eslintbot commentedDec 18, 2019

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

Copy link

codecovbot commentedDec 18, 2019•
edited
Loading

Codecov Report

Merging#1346 intomaster willincrease coverage by0.03%.
The diff coverage is93.75%.

@@            Coverage Diff             @@##           master    #1346      +/-   ##==========================================+ Coverage   93.94%   93.98%   +0.03%==========================================  Files         131      131                Lines        5865     5864       -1       Branches     1662     1662              ==========================================+ Hits         5510     5511       +1+ Misses        188      187       -1+ Partials      167      166       -1

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/member-naming.ts	`100% <ø> (ø)`	⬆️
...-plugin/src/rules/explicit-member-accessibility.ts	`89.09% <100%> (ø)`	⬆️
...ackages/eslint-plugin/src/rules/member-ordering.ts	`92.3% <100%> (ø)`	⬆️
...t-plugin/src/rules/adjacent-overload-signatures.ts	`93.02% <100%> (ø)`	⬆️
packages/eslint-plugin/src/util/misc.ts	`92.85% <90.9%> (+6.65%)`	⬆️

Copy link

Collaborator

armano2 commentedDec 18, 2019•
edited
Loading

~~small question about new type, key can be whatever but only if itscomputed~~

nvm i see you created ticket for this

Copy link

MemberAuthor

bradzacher commentedDec 18, 2019

See#1345
I've almost got a PR ready for this.

bradzacher changed the title~~chore: tighten up property name and destructuring types~~feat(typescript-estree): tighten up property name and destructuring types

Dec 18, 2019

bradzacher mentioned this pull request

Dec 18, 2019

feat(typescript-estree): computed members discriminated unions#1349

Merged

bradzacher changed the title~~feat(typescript-estree): tighten up property name and destructuring types~~feat(typescript-estree): tighten prop name and destructure types

Dec 18, 2019

bradzacher merged commitf335c50 intomaster

Dec 18, 2019

bradzacher deleted the minor-cleanup branch

December 18, 2019 08:43