Thanks for the PR,@G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

This overall LGTM, but it is technically a breaking change for direct consumers ofts-estree (like prettier cc@thorn0).

I'm thinking we should probably look to doing a 3.0.0 release v soon, as the number of things is starting to reach a decent sized pile (see the milestone) cc@JamesHenry

@bradzacher not entirely sure what I can do about the diff coverage, as it doesn't seem to like the fact that I force pushed, and removed so many lines fromparser.

I can't find a nice chunk where I'm missing coverage that I can hit easily :/

@G-Rath
https://codecov.io/gh/typescript-eslint/typescript-eslint/compare/b5a52a3aae85fce3bc45b39a2107a00d2655f5f9...732668047bfd2658fb3ad884a4732896974a973b/diff#D5-1140

Just one branch codecov doesn't think you've tested.

Also please be careful with your @ tagging. My username isn't the first "brad" username alphabetically, and github isn't smart enough to be contextually aware. (I've emailed them about it, but they are yet to fix it..)

@bradzacher Turns out that wasn't actually needed - Let me know if there's any other changes you'd like made for this 😄

Also cheers for pointing out the wrong tagging 😬

Codecov Report

Merging#1289 intov3 willdecrease coverage by0.03%.
The diff coverage is87.17%.

@@            Coverage Diff             @@##               v3    #1289      +/-   ##==========================================- Coverage   93.91%   93.87%   -0.04%==========================================  Files         171      172       +1       Lines        7787     7805      +18       Branches     2238     2240       +2     ==========================================+ Hits         7313     7327      +14- Misses        217      221       +4  Partials      257      257