Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): make FunctionDeclaration.body non-null#1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intotypescript-eslint:masterfromG-Rath:mark-FunctionDeclaration-body-as-not-null
Nov 30, 2019
Merged

fix(typescript-estree): make FunctionDeclaration.body non-null#1288

bradzacher merged 1 commit intotypescript-eslint:masterfromG-Rath:mark-FunctionDeclaration-body-as-not-null
Nov 30, 2019

Conversation

G-Rath
Copy link
Contributor

This is half of#734:

I didn't realise it, but in#156, it added handling to convert function declarations with no body into TSFunctionDeclaration (https://github.com/typescript-eslint/typescript-eslint/pull/156/files#diff-68b2b0b0d2d0ff1846b1114472008332R674)

So it looks like there's no case now that a FunctionDeclaration can have no body?

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitorsper day.

@bradzacherbradzacher changed the titlefix(ts-estree): markbody ofFunctionDeclaration notnullfix(typescript-estree):FunctionDeclaration.body should be non-nullableNov 30, 2019
@bradzacherbradzacher added the bugSomething isn't working labelNov 30, 2019
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - thanks for doing this!

@bradzacherbradzacher changed the titlefix(typescript-estree):FunctionDeclaration.body should be non-nullablefix(typescript-estree): make FunctionDeclaration.body non-nullNov 30, 2019
@bradzacherbradzacher merged commitdc73510 intotypescript-eslint:masterNov 30, 2019
@G-Rath
Copy link
ContributorAuthor

No problem - I've almost finished doing the second half, which I'll push up in a few minutes for review.

bradzacher reacted with thumbs up emoji

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
bugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@G-Rath@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp