Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
feat(eslint-plugin): Migrate plugin to ts#120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
# Conflicts:#packages/eslint-plugin/lib/util.js#packages/eslint-plugin/src/lib/rules/no-object-literal-type-assertion.ts
# Conflicts:#packages/eslint-plugin/lib/rules/adjacent-overload-signatures.js#packages/eslint-plugin/lib/util.js#packages/eslint-plugin/package.json#packages/parser/src/eslint-scope.d.ts#packages/parser/src/parser.ts#packages/parser/src/typings.d.ts#packages/parser/typings/eslint-scope.d.ts#packages/typescript-estree/package.json#packages/typescript-estree/src/node-utils.ts#packages/typescript-estree/src/parser.ts
# Conflicts:#packages/eslint-plugin/lib/rules/no-unnecessary-type-assertion.js
armano2 commentedFeb 10, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Can we split this PR to few smaller one and merge them one by one?
right now this PR is getting bigger and bigger and its really hard to review and check if there is no actual issues |
7404717
to917a9f1
Comparecan you update - TSEmptyBodyFunctionExpression(node: TSESTree.FunctionExpression): void+ TSEmptyBodyFunctionExpression(node: TSESTree.TSEmptyBodyFunctionExpression): void |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Migrates eslint-plugin to typescript.
There's a big refactor in here to make creating a rule easier / more standardised.
messageId
.docs
.category
,description
, andrecommended
.url
to the meta.TOptions
type.Build is passing across the board.
.js.map
and.d.ts.map
files.Tests have been largely untouched apart from the rename, and they are all passing.
closes#47
closes#40
Waiting for the following PRs to be merged in to master:
#178,#192,#204,#215,#231
Closed waiting PRs
#155,#194,#199,#206,#222,#226,#232