Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(eslint-plugin): Migrate plugin to ts#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 97 commits intomasterfrommigrate-plugin-to-ts
Feb 11, 2019

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedJan 22, 2019
edited by j-f1
Loading

Migrates eslint-plugin to typescript.
There's a big refactor in here to make creating a rule easier / more standardised.

  • Types are a lot stricter:
    • Rule metamust usemessageId.
    • Rule metamust includedocs.
      • Docsmust includecategory,description, andrecommended.
  • Reduced boilerplate:

Build is passing across the board.

  • Note that the packages will now include.js.map and.d.ts.map files.

Tests have been largely untouched apart from the rename, and they are all passing.

closes#47
closes#40

Waiting for the following PRs to be merged in to master:
#178,#192,#204,#215,#231

Closed waiting PRs
#155,#194,#199,#206,#222,#226,#232

aboyton reacted with hooray emojiaboyton, 43081j, and sindresorhus reacted with heart emoji
@bradzacherbradzacher added the DO NOT MERGEPRs which should not be merged yet labelJan 22, 2019
@bradzacherbradzacher self-assigned thisJan 22, 2019
armano2
armano2 previously approved these changesFeb 7, 2019
# Conflicts:#packages/eslint-plugin/lib/rules/adjacent-overload-signatures.js#packages/eslint-plugin/lib/util.js#packages/eslint-plugin/package.json#packages/parser/src/eslint-scope.d.ts#packages/parser/src/parser.ts#packages/parser/src/typings.d.ts#packages/parser/typings/eslint-scope.d.ts#packages/typescript-estree/package.json#packages/typescript-estree/src/node-utils.ts#packages/typescript-estree/src/parser.ts
@bradzacherbradzacher added the blocked by another PRPRs which are ready to go but waiting on another PR labelFeb 7, 2019
# Conflicts:#packages/eslint-plugin/lib/rules/no-unnecessary-type-assertion.js
@armano2
Copy link
Collaborator

armano2 commentedFeb 10, 2019
edited
Loading

Can we split this PR to few smaller one and merge them one by one?

  1. add typecheck for tests (new tsconfig.json configs)
  2. add new types and export them to from parser
  3. changes to rules and type definition for plugin

right now this PR is getting bigger and bigger and its really hard to review and check if there is no actual issues

@armano2
Copy link
Collaborator

can you updateanalyze-scope.ts,

- TSEmptyBodyFunctionExpression(node: TSESTree.FunctionExpression): void+ TSEmptyBodyFunctionExpression(node: TSESTree.TSEmptyBodyFunctionExpression): void

@JamesHenryJamesHenry removed the blocked by another PRPRs which are ready to go but waiting on another PR labelFeb 11, 2019
@JamesHenryJamesHenry merged commit61c60dc intomasterFeb 11, 2019
@bradzacherbradzacher deleted the migrate-plugin-to-ts branchFebruary 11, 2019 02:22
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@platinumazureplatinumazureplatinumazure left review comments

@43081j43081j43081j left review comments

@j-f1j-f1j-f1 left review comments

@armano2armano2armano2 approved these changes

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees

@bradzacherbradzacher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Converting rules to be in TypeScript Provide documentation for writing eslint rules in typescript
6 participants
@bradzacher@armano2@platinumazure@JamesHenry@43081j@j-f1

[8]ページ先頭

©2009-2025 Movatter.jp