Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [prefer-optional-chain] remove dangling closing parenthesis#11865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mdm317 wants to merge1 commit intotypescript-eslint:main
base:main
Choose a base branch
Loading
frommdm317:fix-11818-prefer-optional-chain-addtional-paren

Conversation

@mdm317
Copy link
Contributor

@mdm317mdm317 commentedDec 21, 2025•
edited
Loading

PR Checklist

Overview

foo && (foo.bar && (foo.bar as any).baz) =>foo?.bar && (foo.bar as any).baz

foo && (foo.bar && baz) =>foo?.bar && baz

new playground link

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedDec 21, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit4d73fdb
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/6948054ded7b520008e039d1
😎 Deploy Previewhttps://deploy-preview-11865--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🟢 up 19 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedDec 21, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit4d73fdb

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 7sView ↗
nx run-many -t lint✅ Succeeded3m 9sView ↗
nx run-many -t typecheck✅ Succeeded1m 55sView ↗
nx run integration-tests:test✅ Succeeded6sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded3sView ↗
nx test typescript-estree --coverage=false✅ Succeeded1sView ↗
nx run generate-configs✅ Succeeded7sView ↗
nx run types:build✅ Succeeded2sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-12-21 14:45:30 UTC

@codecov
Copy link

codecovbot commentedDec 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.59%. Comparing base (8017d07) to head (4d73fdb).

Additional details and impacted files
@@           Coverage Diff           @@##             main   #11865   +/-   ##=======================================  Coverage   90.59%   90.59%           =======================================  Files         524      524             Lines       53410    53442   +32       Branches     8918     8926    +8     =======================================+ Hits        48385    48417   +32  Misses       5012     5012             Partials       13       13
FlagCoverage Δ
unittest90.59% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
.../rules/prefer-optional-chain-utils/analyzeChain.ts100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdm317mdm317 changed the titlefix(eslint-plugin): [prefer-optional-chain] remove dangling closing parenthesisfix(eslint-plugin): [prefer-optional-chain] remove dangling closing parenthesisDec 21, 2025
@mdm317mdm317 marked this pull request as ready for reviewDecember 21, 2025 16:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [prefer-optional-chain] suggestion produces syntax error when there's additional parentheses

1 participant

@mdm317
[8]ページ先頭
©2009-2025 Movatter.jp