Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: explore switching two test file to VFS#11853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ntdiary wants to merge4 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromntdiary:vfs-exploration

Conversation

@ntdiary
Copy link
Contributor

@ntdiaryntdiary commentedDec 17, 2025
edited
Loading

PR Checklist

Overview

test files:consistent-type-exports.test.ts,no-deprecated.test.ts

Key code changes

  1. Within a test file, use tagged template to setup common fixture.
  2. Add an internalsys field to the parser. This is ats.System instance required by bothts.createWatchCompilerHost andtsserver.server.ProjectService.
  3. Add ahost field to theParserServicesWithTypeInformation, which is required as a param byts.resolveModuleName(inconsistent-type-exports.ts).

Execution flow

  1. Callfixture tag function to setup the common fixture and return asys instance.
  2. createRuleTesterWithTypes will passsys to the parser and return theruleTester instance.
  3. ruleTester will callsys.writeFile to write the code to VFS beforelinter.verify (inrunRuleForItem)

💖

JoshuaKGoldberg reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ntdiary!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedDec 17, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit4daa0b7
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/69426e4ff1c319000817fc7d
😎 Deploy Previewhttps://deploy-preview-11853--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 18 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedDec 17, 2025
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable themin workspace settings.


View yourCI Pipeline Execution ↗ for commit4daa0b7

CommandStatusDurationResult
nx test eslint-plugin❌ Failed6m 30sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded5m 15sView ↗
nx run types:build✅ Succeeded2sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded11sView ↗
nx run integration-tests:test✅ Succeeded7sView ↗
nx test typescript-estree --coverage=false✅ Succeeded19sView ↗
nx run generate-configs✅ Succeeded8sView ↗
nx run-many --target=build --parallel --exclude...✅ Succeeded25sView ↗
Additional runs (26)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-12-17 08:58:48 UTC

@ntdiaryntdiary changed the titlechore: explore switching two test file to vfschore: explore switching two test file to VFSDec 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Explore switching tests to @typescript/vfs

1 participant

@ntdiary

[8]ページ先頭

©2009-2025 Movatter.jp