Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(type-utils): detect nested any in isUnsafeAssignment to flag unsafe object arguments#11834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
OleksandraKordonets wants to merge5 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromOleksandraKordonets:issue11801

Conversation

@OleksandraKordonets
Copy link
Contributor

PR Checklist

Overview

ExtendisUnsafeAssignment to walk object types structurally with cycle guards and early exits, so nestedany in object arguments, unions, tuples, arrays, and index signatures are detected even when shapes are inline or via aliases, not only when the generic bases match. This aligns with the goal of the no-unsafe rules to catch any flowing through call sites and assignments, and it expands on the helper’s current simple top level behavior. All no-unsafe rules that call the helper benefit, includingno-unsafe-argument,no-unsafe-assignment, and, by extension, related rules that rely on the same type-level check, the generic fast path remains for identical bases while inline shapes now flag, andno-unsafe-assignment suppresses a duplicate top level diagnostic when a nested property already errors.

Tests cover shallow and nested objects inpackages/type-utils/tests/isUnsafeAssignment.test.ts plus the issue’s repro inpackages/eslint-plugin/tests/rules/no-unsafe-argument.test.ts, a small website config tweak avoids spreading any to satisfy the stricter checks, and performance is guarded with early exits, default lib skipping, and cycle tracking.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@OleksandraKordonets!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedDec 10, 2025
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitb669595
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/693b703084f82a00080c79fe
😎 Deploy Previewhttps://deploy-preview-11834--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedDec 10, 2025
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable themin workspace settings.


View yourCI Pipeline Execution ↗ for commitb669595

CommandStatusDurationResult
nx run-many -t lint❌ Failed3m 20sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded5m 8sView ↗
nx run-many -t typecheck✅ Succeeded2m 10sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded10sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded2sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
nx run generate-configs✅ Succeeded5sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-12-12 01:43:26 UTC

@codecov
Copy link

codecovbot commentedDec 10, 2025
edited
Loading

Codecov Report

❌ Patch coverage is90.00000% with22 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.54%. Comparing base (dd96947) to head (b669595).

Files with missing linesPatch %Lines
packages/type-utils/src/isUnsafeAssignment.ts89.62%22 Missing⚠️
Additional details and impacted files
@@           Coverage Diff            @@##             main   #11834    +/-   ##========================================  Coverage   90.53%   90.54%            ========================================  Files         523      523              Lines       53096    53311   +215       Branches     8838     8897    +59     ========================================+ Hits        48073    48268   +195- Misses       5010     5030    +20  Partials       13       13
FlagCoverage Δ
unittest90.54% <90.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts97.57% <100.00%> (+0.04%)⬆️
packages/typescript-estree/src/convert.ts30.89% <100.00%> (ø)
packages/type-utils/src/isUnsafeAssignment.ts90.42% <89.62%> (-0.12%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OleksandraKordonets
Copy link
ContributorAuthor

@JoshuaKGoldberg
Hi, I wanted to ask for some guidance on the CI lint failures here.
Earlier I fixed the lint errors for this branch incommit 1d01bd4, but after I added tests, the lint job started failing again. I can fix these, but it would mean touching extra files outside the core of this PR. Before I do that, I wanted to ask what you prefer. Should I keep this PR focused on my solution and leave the other lint issues for a follow up, or is it ok to include those extra lint fixes here so CI passes? I want to follow the project style and avoid unnecessary changes, so any guidance would be very helpful. Thank you

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: [no-unsafe-*] checkanys nested inside object arguments

1 participant

@OleksandraKordonets

[8]ページ先頭

©2009-2025 Movatter.jp