Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [method-signature-style] ignore methods that returnthis#11813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
JoshuaKGoldberg wants to merge4 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromJoshuaKGoldberg:method-signature-style-ignore-this

Conversation

@JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds a utility method to recurse through the AST similar tots.forEachChild.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedDec 1, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit2d80906
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/692dce3ee80ead000858b09e
😎 Deploy Previewhttps://deploy-preview-11813--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 93 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedDec 1, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit2d80906

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 13sView ↗
nx run-many -t lint✅ Succeeded3m 17sView ↗
nx run-many -t typecheck✅ Succeeded1m 56sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded5sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded2sView ↗
nx run generate-configs✅ Succeeded8sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-12-01 17:32:15 UTC

@codecov
Copy link

codecovbot commentedDec 1, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is96.00000% with4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.54%. Comparing base (5ac66a6) to head (2d80906).

Files with missing linesPatch %Lines
.../eslint-plugin/src/rules/method-signature-style.ts96.49%2 Missing⚠️
packages/eslint-plugin/src/util/astUtils.ts95.34%2 Missing⚠️
Additional details and impacted files
@@           Coverage Diff           @@##             main   #11813   +/-   ##=======================================  Coverage   90.53%   90.54%           =======================================  Files         523      523             Lines       53097    53155   +58       Branches     8838     8856   +18     =======================================+ Hits        48074    48128   +54- Misses       5010     5014    +4  Partials       13       13
FlagCoverage Δ
unittest90.54% <96.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
.../eslint-plugin/src/rules/method-signature-style.ts93.01% <96.49%> (-0.45%)⬇️
packages/eslint-plugin/src/util/astUtils.ts95.78% <95.34%> (-0.37%)⬇️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldbergJoshuaKGoldberg requested review froma team and removed request fora teamDecember 1, 2025 16:12
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as draftDecember 1, 2025 16:15
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewDecember 1, 2025 18:48
@JoshuaKGoldbergJoshuaKGoldberg requested a review froma teamDecember 1, 2025 18:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[method-signature-style] Shouldn't affect methods that usethis

1 participant

@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp