Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): revert "[no-redundant-type-constituents] use assignability checking for redundancy checks"#11812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedDec 1, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit9a96603
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/692da2859a4d2b0008c386ce
😎 Deploy Previewhttps://deploy-preview-11812--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 87 (🔴 down 11 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedDec 1, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit9a96603

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded5m 11sView ↗
nx run-many -t lint✅ Succeeded3m 10sView ↗
nx run-many -t typecheck✅ Succeeded2m 26sView ↗
nx run types:build✅ Succeeded1sView ↗
nx run generate-configs✅ Succeeded7sView ↗
nx test typescript-estree --coverage=false✅ Succeeded21sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded9sView ↗
nx run integration-tests:test✅ Succeeded4sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-12-01 14:29:17 UTC

@JoshuaKGoldbergJoshuaKGoldberg changed the titleRevert "feat(eslint-plugin): [no-redundant-type-constituents] use assignability checking for redundancy checks"fix(eslint-plugin): revert "feat(eslint-plugin): [no-redundant-type-constituents] use assignability checking for redundancy checks"Dec 1, 2025
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin): revert "feat(eslint-plugin): [no-redundant-type-constituents] use assignability checking for redundancy checks"fix(eslint-plugin): revert "[no-redundant-type-constituents] use assignability checking for redundancy checks"Dec 1, 2025
@codecov
Copy link

codecovbot commentedDec 1, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is95.72954% with12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.53%. Comparing base (f8b2bb4) to head (9a96603).
⚠️ Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
...plugin/src/rules/no-redundant-type-constituents.ts96.40%10 Missing⚠️
...escript-estree/src/semantic-or-syntactic-errors.ts0.00%2 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main   #11812      +/-   ##==========================================+ Coverage   90.49%   90.53%   +0.04%==========================================  Files         523      523                Lines       53386    53097     -289       Branches     8919     8838      -81     ==========================================- Hits        48311    48074     -237+ Misses       5061     5010      -51+ Partials       14       13       -1
FlagCoverage Δ
unittest90.53% <95.72%> (+0.04%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts93.24% <100.00%> (ø)
...nt-plugin/src/rules/related-getter-setter-pairs.ts100.00% <ø> (ø)
...escript-estree/src/semantic-or-syntactic-errors.ts2.32% <0.00%> (ø)
...plugin/src/rules/no-redundant-type-constituents.ts97.64% <96.40%> (+4.22%)⬆️

... and1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldbergJoshuaKGoldberg merged commit5ac66a6 intomainDec 1, 2025
74 of 76 checks passed
@JoshuaKGoldbergJoshuaKGoldberg deleted the revert-10744-7742-no-redundant-type-constituents branchDecember 1, 2025 14:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
[8]ページ先頭
©2009-2025 Movatter.jp