typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

feat(eslint-plugin): use`Intl.Segmenter` instead of`graphemer`#11804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

JstnMcBrd wants to merge2 commits intotypescript-eslint:main

base:main

Choose a base branch

fromJstnMcBrd:mcb/fix-11803

Open

feat(eslint-plugin): use`Intl.Segmenter` instead of`graphemer`#11804

JstnMcBrd wants to merge2 commits intotypescript-eslint:mainfromJstnMcBrd:mcb/fix-11803

+3 −14

Conversation

Copy link

JstnMcBrd commentedNov 27, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesEnhancement: useIntl.Segmenter instead ofgraphemer #11803
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

See the description of#11803 for the backstory.

UseIntl.Segmenter instead ofgraphemer

3d8a5dc

Copy link

Contributor

typescript-eslintbot commentedNov 27, 2025

Thanks for the PR,@JstnMcBrd!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 27, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`e823a50`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/692806c01e73200008a24b09
😎 Deploy Preview	https://deploy-preview-11804--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 93 (🔴 down 5 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedNov 27, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commite823a50

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 10s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 18s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	1m 58s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	3s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	1s	View ↗
`nx run generate-configs`	✅ Succeeded	8s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run types:build`	✅ Succeeded	2s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-11-27 08:20:26 UTC

Re-add nullish coalescing (accidentally removed)

e823a50

Copy link

codecovbot commentedNov 27, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.49%. Comparing base (3252978) to head (e823a50).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #11804      +/-   ##==========================================- Coverage   90.49%   90.49%   -0.01%==========================================  Files         522      522                Lines       53360    53359       -1       Branches     8911     8911              ==========================================- Hits        48286    48285       -1  Misses       5059     5059                Partials       15       15

Flag	Coverage Δ
unittest	`90.49% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/util/getStringLength.ts	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.