Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [no-unnecessary-condition] check type predicates based on assignability#11799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
kirkwaiblinger wants to merge5 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromkirkwaiblinger:nuc-check-type-predicates-assignability

Conversation

@kirkwaiblinger
Copy link
Member

PR Checklist

Overview

TODO

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedNov 26, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitc17df5c
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/6926d57e05bf6b00083a9b99
😎 Deploy Previewhttps://deploy-preview-11799--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedNov 26, 2025•
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable themin workspace settings.

View yourCI Pipeline Execution ↗ for commitc17df5c

CommandStatusDurationResult
nx run-many -t lint❌ Failed3m 12sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded5m 13sView ↗
nx run-many -t typecheck✅ Succeeded2m 10sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded10sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded2sView ↗
nx run generate-configs✅ Succeeded6sView ↗
nx run integration-tests:test✅ Succeeded3sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-11-26 10:40:13 UTC

@codecov
Copy link

codecovbot commentedNov 26, 2025

Codecov Report

❌ Patch coverage is89.13043% with5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.49%. Comparing base (17601fc) to head (c17df5c).

Files with missing linesPatch %Lines
...slint-plugin/src/rules/no-unnecessary-condition.ts85.29%4 Missing and 1 partial⚠️

❌ Your patch check has failed because the patch coverage (89.13%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #11799      +/-   ##==========================================- Coverage   90.49%   90.49%   -0.01%==========================================  Files         522      523       +1       Lines       53357    53385      +28       Branches     8909     8919      +10     ==========================================+ Hits        48284    48309      +25- Misses       5057     5059       +2- Partials       16       17       +1
FlagCoverage Δ
unittest90.49% <89.13%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
.../eslint-plugin/src/rules/class-methods-use-this.ts100.00% <100.00%> (ø)
...plugin/src/rules/no-unnecessary-type-parameters.ts97.08% <ø> (ø)
...slint-plugin/src/rules/no-unsafe-type-assertion.ts100.00% <100.00%> (ø)
packages/eslint-plugin/src/util/isObjectType.ts100.00% <100.00%> (ø)
...ckages/rule-tester/src/utils/flat-config-schema.ts40.65% <ø> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts98.90% <85.29%> (-0.67%)⬇️

... and1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: [no-unnecessary-condition] use assignability checks incheckTypePredicates

1 participant

@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp